Re: [PR] [SPARK-42891][CONNECT][PYTHON] Implement CoGrouped Map API [spark]

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #40487:
URL: https://github.com/apache/spark/pull/40487#discussion_r1403809250


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -1950,6 +1950,46 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation:
         return plan
 
 
+class CoGroupMap(LogicalPlan):
+    """Logical plan object for a CoGroup Map API: applyInPandas."""
+
+    def __init__(
+        self,
+        input: Optional["LogicalPlan"],
+        input_grouping_cols: Sequence[Column],
+        other: Optional["LogicalPlan"],
+        other_grouping_cols: Sequence[Column],
+        function: "UserDefinedFunction",
+        cols: List[Column],

Review Comment:
   @xinrong-meng just realised that we don't use this variable. Should we remove? or should it be assigned to somewhere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org