[GitHub] [sling-jspc-maven-plugin] karlpauls commented on pull request #6: SLING-10887: allow to load dependencies from a feature

[GitBox <gi...@apache.org>]

karlpauls commented on pull request #6:
URL: https://github.com/apache/sling-jspc-maven-plugin/pull/6#issuecomment-952990048


   @cziegeler, @raducotescu - work in progress but feedback welcome. The idea is to enable something like:
   
   ```
   <plugin>
                   <groupId>org.apache.sling</groupId>
                   <artifactId>jspc-maven-plugin</artifactId>
                   <configuration>
                       <generateCompilationReport>true</generateCompilationReport>
                       <feature>
                           <featureId> 
                              <groupId>org.apache.sling</groupId>
                              <artifactId>foo-feature</artifactId>
                                <version>0.0.1</version>
                                <type>slingosgifeature</type>
                           </featureId>
                       </feature>
                   </configuration>
                   <executions>
                       <execution>
                           <goals>
                               <goal>jspc</goal>
                           </goals>
                       </execution>
                   </executions>
               </plugin>
   ```
   Which would make it so that classes are loaded from the resolved bundles of the feature and tlds would be loaded from there as well. Unfortunately, I had to fork the commons class loader classes as they right now only load from ACTIVE bundles and I didn't want to start the bundles.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org