[jira] [Commented] (MNG-6799) avoid model interpolation instability risk: ensure StringVisitorModelInterpolator replaces StringSearchModelInterpolator

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-6799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069882#comment-17069882 ] 

Hudson commented on MNG-6799:
-----------------------------

Build failed in Jenkins: Maven TLP » maven-studies » maven-metrics #4

See https://builds.apache.org/job/maven-box/job/maven-studies/job/maven-metrics/4/

> avoid model interpolation instability risk: ensure StringVisitorModelInterpolator replaces StringSearchModelInterpolator
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-6799
>                 URL: https://issues.apache.org/jira/browse/MNG-6799
>             Project: Maven
>          Issue Type: Improvement
>          Components: Inheritance and Interpolation
>    Affects Versions: 3.6.2
>            Reporter: Herve Boutemy
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: 3.6.3
>
>
> as discovered recently and [shared on dev ML|https://lists.apache.org/thread.html/efab59150580f27de386386730e3816188ea2d27faa5fa4c96934149@%3Cdev.maven.apache.org%3E], in maven-model-builder, [StringVisitorModelInterpolator|http://maven.apache.org/ref/3.6.2/maven-model-builder/apidocs/org/apache/maven/model/interpolation/StringVisitorModelInterpolator.html] introduced by MNG-6697 in Maven 3.6.2 is meant to replace [StringSearchModelInterpolator|http://maven.apache.org/ref/3.6.2/maven-model-builder/apidocs/org/apache/maven/model/interpolation/StringSearchModelInterpolator.html]
> but currently, both can be injected and the selection of one against the other depends on the order of generated CDI descriptors: if you're lucky, StringVisitorModelInterpolator appear first, but if you're not, StringSearchModelInterpolator will do instead.
> In addition, with Reproducible Builds being introduced in MNG-6789, the order that is introduced is String lexical order: StringSearchModelInterpolator is then before StringVisitorModelInterpolator then with Reproducible Builds we get the unwanted result in a reproducible way...
> we need to ensure that StringVisitorModelInterpolator will be used instead of StringSearchModelInterpolator



--
This message was sent by Atlassian Jira
(v8.3.4#803005)