You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/07/13 07:25:23 UTC
[GitHub] flink pull request #4316: [FLINK-6105] Use InterruptedIOException instead of...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4316
[FLINK-6105] Use InterruptedIOException instead of IOException
This is my first commit of this. It might be have other places also do this change, but I am not sure now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6105
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4316.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4316
----
commit 8fb6cf5926643e4c7de967eafa0cef358f174431
Author: zhangminglei <zm...@163.com>
Date: 2017-07-13T07:23:20Z
[FLINK-6105] Use InterruptedIOException instead of IOException
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4316
I think InterruptedException should be handled uniformly in HadoopInputFormatBase.java
---
[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4316
We could make this change. I have not seen a lot of use of `InterruptedIOException`, probably because it is a bit of a strange class, with its public mutable int field.
I am +/- 0 on this. Do you have a concrete case where this change would lead to a benefit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4316
@zhangminglei, not sure if you saw @tedyu's comment on the Jira. There are more instances of this in the same file and package. If these are internal classes and Flink is not using `InterruptedIOException` then would the only effect be in logging a different exception?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4316
@greghogan I saw Ted comment on the jira before. But I am not sure whether we will adopt Ted's comments. So, that is why I leave this PR until someone adopt it, I will keep working on this then. As refers to what you said logging a different exception, hmm, probably. I would think it will give us more clear exception. @tedyu What do you think of this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4316
Maybe @tedyu could share some light on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---