You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/06/05 23:06:04 UTC
[jira] [Commented] (HADOOP-12056) Use DirectoryStream in
DiskChecker#checkDirs to detect errors when listing a directory
[ https://issues.apache.org/jira/browse/HADOOP-12056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575222#comment-14575222 ]
Hudson commented on HADOOP-12056:
---------------------------------
SUCCESS: Integrated in Hadoop-trunk-Commit #7979 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7979/])
HADOOP-12056. Use DirectoryStream in DiskChecker#checkDirs to detect errors when listing a directory. Contributed by Zhihai Xu. (wang: rev bc11e158b1726174fae2c7d2e8aa1f5005bf42eb)
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDiskChecker.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/DiskChecker.java
> Use DirectoryStream in DiskChecker#checkDirs to detect errors when listing a directory
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-12056
> URL: https://issues.apache.org/jira/browse/HADOOP-12056
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.7.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Fix For: 2.8.0
>
> Attachments: HADOOP-12056.000.patch, HADOOP-12056.001.patch, HADOOP-12056.002.patch, HADOOP-12056.003.patch
>
>
> DiskChecker#checkDirs should check null pointer for the return value from File#listFiles. Based on the document for File#listFiles at https://docs.oracle.com/javase/7/docs/api/java/io/File.html#listFiles() :
> {code}
> Returns null if an I/O error occurs.
> {code}
> So it will be good to check null pointer and throw DiskErrorException if it is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)