You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/30 03:30:41 UTC

[GitHub] [tvm] mshr-h opened a new pull request #9157: [Caffe Frontend] Add support for Permute layer

mshr-h opened a new pull request #9157:
URL: https://github.com/apache/tvm/pull/9157


   Added Permute layer support.
   Related to #6206, #9060
   
   @fernchen @zhiics @tqchen @FrozenGene
   Can you take a look at this PR, please? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #9157: [Caffe Frontend] Add support for Permute layer

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #9157:
URL: https://github.com/apache/tvm/pull/9157#issuecomment-1008441219


   @mshr-h please take a look at the CI problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mshr-h commented on pull request #9157: [Caffe Frontend] Add support for Permute layer

Posted by GitBox <gi...@apache.org>.
mshr-h commented on pull request #9157:
URL: https://github.com/apache/tvm/pull/9157#issuecomment-1011574513


   hi @masahi thank you for your reply.
   I re-run CI and everything has passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mshr-h commented on pull request #9157: [Caffe Frontend] Add support for Permute layer

Posted by GitBox <gi...@apache.org>.
mshr-h commented on pull request #9157:
URL: https://github.com/apache/tvm/pull/9157#issuecomment-1005582132


   Since #9060 was merged, `tvm-ci/pr-merge` should be passing correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi merged pull request #9157: [Caffe Frontend] Add support for Permute layer

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #9157:
URL: https://github.com/apache/tvm/pull/9157


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] FrozenGene commented on a change in pull request #9157: [Caffe Frontend] Add support for Permute layer

Posted by GitBox <gi...@apache.org>.
FrozenGene commented on a change in pull request #9157:
URL: https://github.com/apache/tvm/pull/9157#discussion_r719032634



##########
File path: tests/python/frontend/caffe/test_forward.py
##########
@@ -586,6 +586,27 @@ def test_forward_LRN():
     _test_lrn(data, local_size=3, alpha=2.0, beta=0.5, k=2.0)
 
 
+#######################################################################
+# Permute
+# -----------

Review comment:
       Alignment




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mshr-h commented on a change in pull request #9157: [Caffe Frontend] Add support for Permute layer

Posted by GitBox <gi...@apache.org>.
mshr-h commented on a change in pull request #9157:
URL: https://github.com/apache/tvm/pull/9157#discussion_r719172534



##########
File path: tests/python/frontend/caffe/test_forward.py
##########
@@ -586,6 +586,27 @@ def test_forward_LRN():
     _test_lrn(data, local_size=3, alpha=2.0, beta=0.5, k=2.0)
 
 
+#######################################################################
+# Permute
+# -----------

Review comment:
       @FrozenGene 
   Sorry, can you specifically point out what's wrong with the code?
   There seems to be no problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mshr-h commented on a change in pull request #9157: [Caffe Frontend] Add support for Permute layer

Posted by GitBox <gi...@apache.org>.
mshr-h commented on a change in pull request #9157:
URL: https://github.com/apache/tvm/pull/9157#discussion_r725750101



##########
File path: tests/python/frontend/caffe/test_forward.py
##########
@@ -586,6 +586,27 @@ def test_forward_LRN():
     _test_lrn(data, local_size=3, alpha=2.0, beta=0.5, k=2.0)
 
 
+#######################################################################
+# Permute
+# -----------

Review comment:
       @FrozenGene 
   Thanks you very much.
   I fixed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] FrozenGene commented on a change in pull request #9157: [Caffe Frontend] Add support for Permute layer

Posted by GitBox <gi...@apache.org>.
FrozenGene commented on a change in pull request #9157:
URL: https://github.com/apache/tvm/pull/9157#discussion_r724642320



##########
File path: tests/python/frontend/caffe/test_forward.py
##########
@@ -586,6 +586,27 @@ def test_forward_LRN():
     _test_lrn(data, local_size=3, alpha=2.0, beta=0.5, k=2.0)
 
 
+#######################################################################
+# Permute
+# -----------

Review comment:
       Line 590 and Line 591.
   ```python
   # Permute
   # -------
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org