You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2025/10/01 08:57:00 UTC
[jira] [Work logged] (ARTEMIS-5687) Closing an AMQP session via console or management does not send an End frame
[ https://issues.apache.org/jira/browse/ARTEMIS-5687?focusedWorklogId=985297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-985297 ]
ASF GitHub Bot logged work on ARTEMIS-5687:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/25 08:56
Start Date: 01/Oct/25 08:56
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5945:
URL: https://github.com/apache/activemq-artemis/pull/5945#discussion_r2393899406
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSessionTest.java:
##########
@@ -111,4 +113,64 @@ public void testCreateSessionProducerConsumerDoesNotLeakClosable() throws Except
connection.close();
}
+ @Test
+ public void testSessionClosedOnServerEndsClientSession() throws Exception {
+ doTestSessionClosedOnServerEndsClientSession(false, false);
+ }
+
+ @Test
+ public void testSessionClosedOnServerEndsClientSessionWithFailed() throws Exception {
+ doTestSessionClosedOnServerEndsClientSession(true, false);
+ }
+
+ @Test
+ public void testSessionClosedOnServerEndsClientSessionWithFailedAndForced() throws Exception {
+ doTestSessionClosedOnServerEndsClientSession(true, true);
+ }
+
+ @Test
+ public void testSessionClosedOnServerEndsClientSessionForced() throws Exception {
+ doTestSessionClosedOnServerEndsClientSession(false, true);
+ }
+
+ public void doTestSessionClosedOnServerEndsClientSession(boolean failed, boolean forced) throws Exception {
Review Comment:
The arguments arent being used, so the same test is being repeated.
Issue Time Tracking
-------------------
Worklog Id: (was: 985297)
Time Spent: 20m (was: 10m)
> Closing an AMQP session via console or management does not send an End frame
> ----------------------------------------------------------------------------
>
> Key: ARTEMIS-5687
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5687
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.42.0
> Reporter: Timothy A. Bish
> Assignee: Timothy A. Bish
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.43.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When an session from a connected AMQP client is closed on the server side no End frame is sent to the client which can lead to client consumers sitting idle never reading an message and never knowing that their remote session has closed. The close of the session should signal that the server ended the client session so it can react.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact