You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/01/02 23:19:14 UTC

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 )

Change subject: KUDU-2636: LBM supports deleting dead and full containers
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12075/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12075/7//COMMIT_MSG@15
PS7, Line 15: Step1: wrapping up containers in scoped_refptr. [V]
            : Step2: supporting dead containers removal.      [X]
> Could you do step 1 in a separate gerrit change rather than overwriting thi
Thanks. Now that you've created https://gerrit.cloudera.org/c/12121, you should rebase this change on top of that one.



-- 
To view, visit http://gerrit.cloudera.org:8080/12075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d3672ae3c3dd9acd489120d653c44a641537f10
Gerrit-Change-Number: 12075
Gerrit-PatchSet: 7
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Wed, 02 Jan 2019 23:19:14 +0000
Gerrit-HasComments: Yes