You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/09/26 08:35:10 UTC
[GitHub] marcaurele commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.
marcaurele commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/837#discussion_r140989681
##########
File path: plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
##########
@@ -512,7 +512,11 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
});
HostVO host = _hostDao.findById(lbDeviceVo.getHostId());
- _agentMgr.reconnect(host.getId());
+ try {
+ _agentMgr.reconnect(host.getId());
+ } catch (Exception e ) {
+ s_logger.debug("failed to reconnect host "+host);
Review comment:
I would log the message at least at the info level, warn would be better IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services