[GitHub] [hudi] boneanxs commented on a change in pull request #4791: [HUDI-3412] TypedProperties no need to create new set when check key …

[GitBox <gi...@apache.org>]

boneanxs commented on a change in pull request #4791:
URL: https://github.com/apache/hudi/pull/4791#discussion_r804452202



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/TypedProperties.java
##########
@@ -44,27 +43,22 @@ public TypedProperties(Properties defaults) {
   }
 
   private void checkKey(String property) {
-    if (!keyExists(property)) {
+    if (!containsKey(property)) {
       throw new IllegalArgumentException("Property " + property + " not found");

Review comment:
       You mean we can support key with different type? After this, TypedProperties also can only accept keys which is strings, because all public methods can only accept key as String




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org