You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "dilipkumar6306316-art (via GitHub)" <gi...@apache.org> on 2026/01/09 16:12:46 UTC
[PR] fix(custom): restore emphasis for large datasets (#21442) [echarts]
dilipkumar6306316-art opened a new pull request, #21463:
URL: https://github.com/apache/echarts/pull/21463
### Problem
Custom series elements with large datasets (~3000+ points) were being marked as `silent` / `ignore`
by ECharts for performance reasons. As a result, **hover and emphasis (highlighting) did not work**
even when `emphasis` was explicitly defined in `renderItem`. This is tracked in issue #21442.
### Solution
This PR ensures that any **custom element with an `emphasis` state** is not marked as silent or ignored.
The fix is applied in `src/chart/custom/CustomView.ts` just before `toggleHoverEmphasis` is called.
- Only elements with `emphasis` are affected
- `emphasisDisabled` is respected
- Large dataset performance remains unaffected
### How to Test
1. Open the custom series example (CodeSandbox or `http://localhost:9001`)
2. Set `dataCount` to ~3000-4000
3. Hover over the rectangles
4. Observe that emphasis (highlight) works correctly
### Related Issue
Closes #21442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(custom): restore emphasis for large datasets (#21442) [echarts]
Posted by "dilipkumar6306316-art (via GitHub)" <gi...@apache.org>.
dilipkumar6306316-art closed pull request #21463: fix(custom): restore emphasis for large datasets (#21442)
URL: https://github.com/apache/echarts/pull/21463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(custom): restore emphasis for large datasets (#21442) [echarts]
Posted by "dilipkumar6306316-art (via GitHub)" <gi...@apache.org>.
dilipkumar6306316-art commented on PR #21463:
URL: https://github.com/apache/echarts/pull/21463#issuecomment-4103378147
Thank you for your feedback.
I will review the requested changes and update the PR accordingly. Please let me know if there are any specific areas I should focus on.
Thanks for your time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(custom): restore emphasis for large datasets (#21442) [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #21463:
URL: https://github.com/apache/echarts/pull/21463#issuecomment-3729601767
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
Please **DO NOT** commit the files in [dist](https://github.com/apache/echarts/tree/master/dist), [i18n](https://github.com/apache/echarts/tree/master/i18n), and [ssr/client/dist](https://github.com/apache/echarts/tree/master/ssr/client/dist) folders in a non-release pull request. These folders are for release use only.
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: `PR: doc ready`, `PR: awaiting doc`, `PR: doc unchanged`
This message is shown because the PR description doesn't contain the document related template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(custom): restore emphasis for large datasets (#21442) [echarts]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21463:
URL: https://github.com/apache/echarts/pull/21463#issuecomment-3736787568
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21463@292748e
<!-- ECHARTS_PR_PREVIEW -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(custom): restore emphasis for large datasets (#21442) [echarts]
Posted by "dilipkumar6306316-art (via GitHub)" <gi...@apache.org>.
dilipkumar6306316-art commented on PR #21463:
URL: https://github.com/apache/echarts/pull/21463#issuecomment-4103336229
> ### Problem
> Custom series elements with large datasets (~3000+ points) were being marked as `silent` / `ignore` by ECharts for performance reasons. As a result, **hover and emphasis (highlighting) did not work** even when `emphasis` was explicitly defined in `renderItem`. This is tracked in issue #21442.
>
> ### Solution
> This PR ensures that any **custom element with an `emphasis` state** is not marked as silent or ignored. The fix is applied in `src/chart/custom/CustomView.ts` just before `toggleHoverEmphasis` is called.
>
> * Only elements with `emphasis` are affected
> * `emphasisDisabled` is respected
> * Large dataset performance remains unaffected
>
> ### How to Test
> 1. Open the custom series example (CodeSandbox or `http://localhost:9001`)
> 2. Set `dataCount` to ~3000-4000
> 3. Hover over the rectangles
> 4. Observe that emphasis (highlight) works correctly
>
> ### Related Issue
> Closes #21442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org