You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/16 03:40:50 UTC

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12818: PIP 110: Support Topic metadata

gaoran10 commented on a change in pull request #12818:
URL: https://github.com/apache/pulsar/pull/12818#discussion_r749876032



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
##########
@@ -77,6 +77,7 @@
     private int newEntriesCheckDelayInMillis = 10;
     private Clock clock = Clock.systemUTC();
     private ManagedLedgerInterceptor managedLedgerInterceptor;
+    private Map<String, String> topicMetadata;

Review comment:
       Maybe we'd better don't add topic-related concepts in the ManagedLedger package, why not add this in the `PersistentTopic`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org