You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Swapnil Bawaskar <sb...@apache.org> on 2016/02/17 23:30:02 UTC
Review Request 43677: GEODE-970: Remove duplicate HLL classes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43677/
-----------------------------------------------------------
Review request for geode, Darrel Schneider and Sai Boorlagadda.
Repository: geode
Description
-------
HLL classes were duplicated in com.gemstone.gemfire.internal.redis.hll and com.gemstone.gemfire.cache.hdfs.internal.cardinality packages.
They now live in com.gemstone.gemfire.internal.hll package.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/Bits.java 4fa3443f6290062970959466efbb2c856ecf407c
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/CardinalityMergeException.java a63f8e60a83ff34bbb9324eda1053ab883e1a8e4
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/HyperLogLog.java 6d945bcc665737ea1f07127e74f467e08dd66767
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/IBuilder.java 4321dc6206cf14bf712a97670df51e29eee06ebc
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/ICardinality.java ae6d7d6e1d38bd21d8378b9a259dd628ff90e4d3
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/MurmurHash.java bc760a8d14a26d1846123b7c87594de63b87643f
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/RegisterSet.java 6f1b9194edd2ca1bf1c7d601494d826a307c89b0
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/AbstractHoplog.java 636dd91ef3cbfd8cf020a37392f16285a09006d5
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HFileSortedOplog.java 8fc9c8e90f8eb02c75756df4028171160b1a45a0
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HdfsSortedOplogOrganizer.java 9890b3bb2c860be4692128bf01e53efc4ea9e01d
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/Hoplog.java 113e49b574ea782297dcfb2f50948e8882a3738c
gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/SequenceFileHoplog.java 04cbb05f3e4d56863cb1137781a7b82a2843da92
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/RegionProvider.java f9539e59ffd884253cd7c0a7c3c8c3f250ba6c5b
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/Bits.java b204442891ed8bf5ff1c04d4a6713187ad9f49fb
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/CardinalityMergeException.java 139177977aa1e2c11221c3f3967fb3bdc58c1ed4
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/HyperLogLog.java c857db4c28c5494fad984fcad89dc3ed03f563b5
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/HyperLogLogPlus.java 8bba36d886dc0368d905f3d28b9ccfa0d5414e46
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/IBuilder.java e18be29fdecc13860300de66ae865363ecc0e771
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/ICardinality.java f89f91d6a2cf6b89847605b83fbadba1e2d23ddf
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/MurmurHash.java 1c6b9d097cda8fdf3268aec2799d64b89d7df58a
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/PFAddExecutor.java 95af34a77fbb0870d274963c606e221b6144abdd
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/PFCountExecutor.java e0810227a671573c3d0036b87bed2f4c7074cba2
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/PFMergeExecutor.java dd9afbc42a579e56f9e9c830690246f47adc762a
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/RegisterSet.java fcf3a38e1d9852153e6da31aaaa095148fa4ac7a
gemfire-core/src/main/java/com/gemstone/gemfire/redis/GemFireRedisServer.java e90b724c8c613e64e4f18167f24fddbffc674eac
Diff: https://reviews.apache.org/r/43677/diff/
Testing
-------
Thanks,
Swapnil Bawaskar
Re: Review Request 43677: GEODE-970: Remove duplicate HLL classes
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43677/#review119541
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Feb. 17, 2016, 2:29 p.m., Swapnil Bawaskar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43677/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 2:29 p.m.)
>
>
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> HLL classes were duplicated in com.gemstone.gemfire.internal.redis.hll and com.gemstone.gemfire.cache.hdfs.internal.cardinality packages.
> They now live in com.gemstone.gemfire.internal.hll package.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/Bits.java 4fa3443f6290062970959466efbb2c856ecf407c
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/CardinalityMergeException.java a63f8e60a83ff34bbb9324eda1053ab883e1a8e4
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/HyperLogLog.java 6d945bcc665737ea1f07127e74f467e08dd66767
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/IBuilder.java 4321dc6206cf14bf712a97670df51e29eee06ebc
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/ICardinality.java ae6d7d6e1d38bd21d8378b9a259dd628ff90e4d3
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/MurmurHash.java bc760a8d14a26d1846123b7c87594de63b87643f
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/RegisterSet.java 6f1b9194edd2ca1bf1c7d601494d826a307c89b0
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/AbstractHoplog.java 636dd91ef3cbfd8cf020a37392f16285a09006d5
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HFileSortedOplog.java 8fc9c8e90f8eb02c75756df4028171160b1a45a0
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HdfsSortedOplogOrganizer.java 9890b3bb2c860be4692128bf01e53efc4ea9e01d
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/Hoplog.java 113e49b574ea782297dcfb2f50948e8882a3738c
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/SequenceFileHoplog.java 04cbb05f3e4d56863cb1137781a7b82a2843da92
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/RegionProvider.java f9539e59ffd884253cd7c0a7c3c8c3f250ba6c5b
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/Bits.java b204442891ed8bf5ff1c04d4a6713187ad9f49fb
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/CardinalityMergeException.java 139177977aa1e2c11221c3f3967fb3bdc58c1ed4
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/HyperLogLog.java c857db4c28c5494fad984fcad89dc3ed03f563b5
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/HyperLogLogPlus.java 8bba36d886dc0368d905f3d28b9ccfa0d5414e46
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/IBuilder.java e18be29fdecc13860300de66ae865363ecc0e771
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/ICardinality.java f89f91d6a2cf6b89847605b83fbadba1e2d23ddf
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/MurmurHash.java 1c6b9d097cda8fdf3268aec2799d64b89d7df58a
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/PFAddExecutor.java 95af34a77fbb0870d274963c606e221b6144abdd
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/PFCountExecutor.java e0810227a671573c3d0036b87bed2f4c7074cba2
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/PFMergeExecutor.java dd9afbc42a579e56f9e9c830690246f47adc762a
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/RegisterSet.java fcf3a38e1d9852153e6da31aaaa095148fa4ac7a
> gemfire-core/src/main/java/com/gemstone/gemfire/redis/GemFireRedisServer.java e90b724c8c613e64e4f18167f24fddbffc674eac
>
> Diff: https://reviews.apache.org/r/43677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapnil Bawaskar
>
>
Re: Review Request 43677: GEODE-970: Remove duplicate HLL classes
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43677/#review119542
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Boorlagadda
On Feb. 17, 2016, 10:29 p.m., Swapnil Bawaskar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43677/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 10:29 p.m.)
>
>
> Review request for geode, Darrel Schneider and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> HLL classes were duplicated in com.gemstone.gemfire.internal.redis.hll and com.gemstone.gemfire.cache.hdfs.internal.cardinality packages.
> They now live in com.gemstone.gemfire.internal.hll package.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/Bits.java 4fa3443f6290062970959466efbb2c856ecf407c
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/CardinalityMergeException.java a63f8e60a83ff34bbb9324eda1053ab883e1a8e4
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/HyperLogLog.java 6d945bcc665737ea1f07127e74f467e08dd66767
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/IBuilder.java 4321dc6206cf14bf712a97670df51e29eee06ebc
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/ICardinality.java ae6d7d6e1d38bd21d8378b9a259dd628ff90e4d3
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/MurmurHash.java bc760a8d14a26d1846123b7c87594de63b87643f
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/cardinality/RegisterSet.java 6f1b9194edd2ca1bf1c7d601494d826a307c89b0
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/AbstractHoplog.java 636dd91ef3cbfd8cf020a37392f16285a09006d5
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HFileSortedOplog.java 8fc9c8e90f8eb02c75756df4028171160b1a45a0
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HdfsSortedOplogOrganizer.java 9890b3bb2c860be4692128bf01e53efc4ea9e01d
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/Hoplog.java 113e49b574ea782297dcfb2f50948e8882a3738c
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/SequenceFileHoplog.java 04cbb05f3e4d56863cb1137781a7b82a2843da92
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/RegionProvider.java f9539e59ffd884253cd7c0a7c3c8c3f250ba6c5b
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/Bits.java b204442891ed8bf5ff1c04d4a6713187ad9f49fb
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/CardinalityMergeException.java 139177977aa1e2c11221c3f3967fb3bdc58c1ed4
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/HyperLogLog.java c857db4c28c5494fad984fcad89dc3ed03f563b5
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/HyperLogLogPlus.java 8bba36d886dc0368d905f3d28b9ccfa0d5414e46
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/IBuilder.java e18be29fdecc13860300de66ae865363ecc0e771
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/ICardinality.java f89f91d6a2cf6b89847605b83fbadba1e2d23ddf
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/MurmurHash.java 1c6b9d097cda8fdf3268aec2799d64b89d7df58a
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/PFAddExecutor.java 95af34a77fbb0870d274963c606e221b6144abdd
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/PFCountExecutor.java e0810227a671573c3d0036b87bed2f4c7074cba2
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/PFMergeExecutor.java dd9afbc42a579e56f9e9c830690246f47adc762a
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/executor/hll/RegisterSet.java fcf3a38e1d9852153e6da31aaaa095148fa4ac7a
> gemfire-core/src/main/java/com/gemstone/gemfire/redis/GemFireRedisServer.java e90b724c8c613e64e4f18167f24fddbffc674eac
>
> Diff: https://reviews.apache.org/r/43677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapnil Bawaskar
>
>