You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/09 19:37:36 UTC

[GitHub] [accumulo] keith-turner edited a comment on pull request #1917: Add info about extension to RFile API javadoc

keith-turner edited a comment on pull request #1917:
URL: https://github.com/apache/accumulo/pull/1917#issuecomment-776188404


   >> We are throwing `IllegalArgumentException`.
   >> `java.lang.IllegalArgumentException: File name test2743857433138030645 has no extension`
   >> `java.lang.IllegalArgumentException: File type dat not supported`
   >
   >Where is that being thrown? I think @keith-turner suggested we throw it in the builder's `to` method, which I agree would >be great.
   
   The `to` method may be nice, I was more concerned about an actionable error message (the error message in the exception contains enough info to fix the problem).  Those messages could be improved to mention the expected extension of `.rf`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org