You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/31 14:44:22 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6975: net/usrsock: allow usrsock *DATA_ACK with no-preload data

anchao opened a new pull request, #6975:
URL: https://github.com/apache/incubator-nuttx/pull/6975

   
   ## Summary
   
   net/usrsock: allow usrsock *DATA_ACK with no-preload data
   
   allow usrsock USRSOCK_MESSAGE_RESPONSE_DATA_ACK with no-preload data
   so addrlen could be updated to valuelen_nontrunc of usrsock_message_datareq_ack_s
   
   ```
   
   nsh> usrsocktest
   ...
   Testing group "basic_getsockname" =>
   	[TEST ASSERT FAILED!]
   		In function "basic_getsockname_open":
   		line 170: Assertion `(ssize_t)((ret)) == (ssize_t)((0))' failed.
   			got value: -1
   			should be: 0
   	Group "basic_getsockname": [FAILED]
   ```
   
   Signed-off-by: chao an <an...@xiaomi.com>
   
   
   ## Impact
   
   ## Testing
   
   Pass the usrsock test:
   https://github.com/apache/incubator-nuttx-apps/blob/master/examples/usrsocktest/usrsocktest_basic_getsockname.c#L168-L170


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6975: net/usrsock: allow usrsock *DATA_ACK with no-preload data

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged PR #6975:
URL: https://github.com/apache/incubator-nuttx/pull/6975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6975: net/usrsock: allow usrsock *DATA_ACK with no-preload data

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6975:
URL: https://github.com/apache/incubator-nuttx/pull/6975#discussion_r960163049


##########
net/usrsock/usrsock_dev.c:
##########
@@ -851,23 +851,26 @@ static ssize_t usrsockdev_write(FAR struct file *filep,
 
       /* Copy data from user-space. */
 
-      ret = iovec_put(conn->resp.datain.iov, conn->resp.datain.iovcnt,
-                      conn->resp.datain.pos, buffer, len);
-      if (ret < 0)

Review Comment:
   should we let iovec_put return 0 in case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org