You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2015/01/07 03:12:37 UTC
Re: Review Request 29439: UnionProcessor misses results for
multi-insert when hive.optimize.union.remove=true
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29439/
-----------------------------------------------------------
(Updated Jan. 7, 2015, 2:12 a.m.)
Review request for hive and John Pullokkaran.
Changes
-------
add notes and test files according to John's comments.
Repository: hive-git
Description
-------
In union_remove_6.q, just change
FROM (
SELECT key, count(1) as values from inputTbl1 group by key
UNION ALL
SELECT key, count(1) as values from inputTbl1 group by key
) a
insert overwrite table outputTbl1 select *
insert overwrite table outputTbl2 select *;
to
FROM (
select * from(
SELECT key, count(1) as values from inputTbl1 group by key
UNION ALL
SELECT key, count(1) as values from inputTbl1 group by key
)subq
) a
insert overwrite table outputTbl1 select *
insert overwrite table outputTbl2 select *;
select * from outputtbl2 will output nothing
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/unionproc/UnionProcFactory.java a985c4f
ql/src/test/queries/clientpositive/union_remove_6_subq.q PRE-CREATION
ql/src/test/results/clientpositive/union_remove_6_subq.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/29439/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 29439: UnionProcessor misses results for
multi-insert when hive.optimize.union.remove=true
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29439/#review67052
-----------------------------------------------------------
Ship it!
Ship It!
- John Pullokkaran
On Jan. 7, 2015, 2:12 a.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29439/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 2:12 a.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> In union_remove_6.q, just change
>
> FROM (
> SELECT key, count(1) as values from inputTbl1 group by key
> UNION ALL
> SELECT key, count(1) as values from inputTbl1 group by key
> ) a
> insert overwrite table outputTbl1 select *
> insert overwrite table outputTbl2 select *;
>
> to
>
> FROM (
> select * from(
> SELECT key, count(1) as values from inputTbl1 group by key
> UNION ALL
> SELECT key, count(1) as values from inputTbl1 group by key
> )subq
> ) a
> insert overwrite table outputTbl1 select *
> insert overwrite table outputTbl2 select *;
>
> select * from outputtbl2 will output nothing
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/unionproc/UnionProcFactory.java a985c4f
> ql/src/test/queries/clientpositive/union_remove_6_subq.q PRE-CREATION
> ql/src/test/results/clientpositive/union_remove_6_subq.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29439/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>