You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/01/14 05:18:15 UTC
[GitHub] [incubator-iceberg] chenjunjiedada commented on issue #684: Support
Decimal in Parquet predicates
chenjunjiedada commented on issue #684: Support Decimal in Parquet predicates
URL: https://github.com/apache/incubator-iceberg/issues/684#issuecomment-574006063
@rdblue, I 'm trying to understand this, please correct me if I'm wrong.
Currently, `ParquetFilters#getParquetPrimitive` doesn't handle the BigDecimal case, we should add branches to translate decimal literal to int, long (, and binary?) according to its precision. So that `ParquetFilter@predicate` can return a matched `pred` correctly. Also because DecimalLiteral uses a default comparator (null first + natural order) which cannot compare binary decimals so we need to create a new comparator such as `BinaryDeciamlComparator`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org