You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/02/22 00:56:36 UTC
[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9388
Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319
......................................................................
[java] fix the regression test for KUDU-2267/KUDU-2319
Previously, a regression test is added to ensure a client with valid
token but without valid Kerberos credentials should be able to connect
to all the masters. However, the test is not construct correctly. This
patch fixs that.
Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
---
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
2 files changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/9388/1
--
To view, visit http://gerrit.cloudera.org:8080/9388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
Gerrit-Change-Number: 9388
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 )
Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
Gerrit-Change-Number: 9388
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 23 Feb 2018 16:55:25 +0000
Gerrit-HasComments: No
[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 )
Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java:
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java@163
PS1, Line 163: KuduTable masterTable,
: KuduRpc<?> parentRpc,
: long defaultTimeoutMs,
> nit: padding
Done
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@83
PS1, Line 83:
> A
Done
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@87
PS1, Line 87: */
> If you base this a top of https://gerrit.cloudera.org/c/9373/, you can enab
Right, I checked out the fix and then this test is passing
--
To view, visit http://gerrit.cloudera.org:8080/9388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
Gerrit-Change-Number: 9388
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 23 Feb 2018 07:38:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9388 )
Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319
......................................................................
[java] fix the regression test for KUDU-2267/KUDU-2319
In the previous commit 0f0e42144, a regression test was added to ensure
a client with valid authn token but without valid Kerberos credentials
should be able to connect to all the masters. However, the test was not
correct. This patch fixes that.
Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
Reviewed-on: http://gerrit.cloudera.org:8080/9388
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
2 files changed, 22 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
Gerrit-Change-Number: 9388
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 )
Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@83
PS1, Line 83: .
> .
Done
--
To view, visit http://gerrit.cloudera.org:8080/9388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
Gerrit-Change-Number: 9388
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 23 Feb 2018 07:42:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 )
Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@9
PS1, Line 9: 44
> was ?
Done
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@10
PS1, Line 10: a cli
> authn token
Done
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@11
PS1, Line 11: asters. However, the test
> was not correct.
Done
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@12
PS1, Line 12: t. T
> fixes
Done
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@13
PS1, Line 13:
> Please add:
Done
--
To view, visit http://gerrit.cloudera.org:8080/9388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
Gerrit-Change-Number: 9388
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 23 Feb 2018 07:41:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 )
Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319
......................................................................
Patch Set 1:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@9
PS1, Line 9: is
was ?
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@10
PS1, Line 10: token
authn token
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@11
PS1, Line 11: is not construct correctly
was not correct.
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@12
PS1, Line 12: fixs
fixes
http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@13
PS1, Line 13:
Please add:
This is a follow-up for 0f0e42144a0d37f57394b373eb75eeb18bc28174.
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java:
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java@163
PS1, Line 163: KuduRpc<?> parentRpc,
: long defaultTimeoutMs,
: Connection.CredentialsPolicy credentialsPolicy) {
nit: padding
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@83
PS1, Line 83: ,
.
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@83
PS1, Line 83: a
A
Also, for better readability, add an empty line between the first sentence and the rest of the description.
http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@87
PS1, Line 87: @Ignore
If you base this a top of https://gerrit.cloudera.org/c/9373/, you can enable this test and verify that it passes.
--
To view, visit http://gerrit.cloudera.org:8080/9388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
Gerrit-Change-Number: 9388
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 23 Feb 2018 05:55:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] fix the regression test for KUDU-2267/KUDU-2319
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9388
to look at the new patch set (#2).
Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319
......................................................................
[java] fix the regression test for KUDU-2267/KUDU-2319
In the previous commit 0f0e42144, a regression test was added to ensure
a client with valid authn token but without valid Kerberos credentials
should be able to connect to all the masters. However, the test was not
correct. This patch fixes that.
Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
---
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
2 files changed, 22 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/9388/2
--
To view, visit http://gerrit.cloudera.org:8080/9388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690
Gerrit-Change-Number: 9388
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins