You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/03/21 12:30:27 UTC
Review Request 19523: Fix Ambari Setup on Ubuntu.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
Bugs: AMBARI-5170
https://issues.apache.org/jira/browse/AMBARI-5170
Repository: ambari
Description
-------
Fix Ambari Setup on Ubuntu.
Need to make sure ambari-server setup works fine on Ubuntu
Diffs
-----
ambari-server/src/main/python/ambari-server.py 5cec271
Diff: https://reviews.apache.org/r/19523/diff/
Testing
-------
----------------------------------------------------------------------
Ran 187 tests in 0.421s
OK
----------------------------------------------------------------------
Total run:506
Total errors:0
Total failures:0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On March 21, 2014, 1:57 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/python/ambari-server.py, line 251
> > <https://reviews.apache.org/r/19523/diff/2/?file=531133#file531133line251>
> >
> > has it been tested under sles/rhel(centos) 5?
"has it been tested under sles/rhel(centos) 5?"
/usr/bin/env are present on all linux platforms (like file or like symlink) and working well
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/#review38089
-----------------------------------------------------------
On March 21, 2014, 11:30 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19523/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 11:30 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-5170
> https://issues.apache.org/jira/browse/AMBARI-5170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix Ambari Setup on Ubuntu.
>
> Need to make sure ambari-server setup works fine on Ubuntu
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 5cec271
>
> Diff: https://reviews.apache.org/r/19523/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 187 tests in 0.421s
>
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On March 21, 2014, 1:57 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/python/ambari-server.py, line 269
> > <https://reviews.apache.org/r/19523/diff/2/?file=531133#file531133line269>
> >
> > do we ever use this value later?
"do we ever use this value later?"
UBUNTU_PG_VERSION = "" - should stay to keep same variable type after executing "UBUNTU_PG_VERSION = sorted("
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/#review38089
-----------------------------------------------------------
On March 21, 2014, 11:30 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19523/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 11:30 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-5170
> https://issues.apache.org/jira/browse/AMBARI-5170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix Ambari Setup on Ubuntu.
>
> Need to make sure ambari-server setup works fine on Ubuntu
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 5cec271
>
> Diff: https://reviews.apache.org/r/19523/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 187 tests in 0.421s
>
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/#review38089
-----------------------------------------------------------
Overall changes look good. It would be great to add unit test coverage
ambari-server/src/main/python/ambari-server.py
<https://reviews.apache.org/r/19523/#comment70063>
has it been tested under sles/rhel(centos) 5?
ambari-server/src/main/python/ambari-server.py
<https://reviews.apache.org/r/19523/#comment70066>
do we ever use this value later?
- Dmitro Lisnichenko
On March 21, 2014, 11:30 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19523/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 11:30 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-5170
> https://issues.apache.org/jira/browse/AMBARI-5170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix Ambari Setup on Ubuntu.
>
> Need to make sure ambari-server setup works fine on Ubuntu
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 5cec271
>
> Diff: https://reviews.apache.org/r/19523/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 187 tests in 0.421s
>
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/#review38463
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 25, 2014, 5:25 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19523/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 5:25 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-5170
> https://issues.apache.org/jira/browse/AMBARI-5170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix Ambari Setup on Ubuntu.
>
> Need to make sure ambari-server setup works fine on Ubuntu
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py acdb683
> ambari-server/src/main/python/ambari_server/utils.py PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py b63a3df
> ambari-server/src/test/python/TestUtils.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19523/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 187 tests in 0.421s
>
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/
-----------------------------------------------------------
(Updated March 25, 2014, 5:25 p.m.)
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Bugs: AMBARI-5170
https://issues.apache.org/jira/browse/AMBARI-5170
Repository: ambari
Description
-------
Fix Ambari Setup on Ubuntu.
Need to make sure ambari-server setup works fine on Ubuntu
Diffs (updated)
-----
ambari-server/src/main/python/ambari-server.py acdb683
ambari-server/src/main/python/ambari_server/utils.py PRE-CREATION
ambari-server/src/test/python/TestAmbariServer.py b63a3df
ambari-server/src/test/python/TestUtils.py PRE-CREATION
Diff: https://reviews.apache.org/r/19523/diff/
Testing
-------
----------------------------------------------------------------------
Ran 187 tests in 0.421s
OK
----------------------------------------------------------------------
Total run:506
Total errors:0
Total failures:0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/#review38452
-----------------------------------------------------------
Ship it!
Looks good
ambari-server/src/main/python/ambari_server/utils.py
<https://reviews.apache.org/r/19523/#comment70652>
minor thing, strange line break
- Dmitro Lisnichenko
On March 25, 2014, 4:54 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19523/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 4:54 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-5170
> https://issues.apache.org/jira/browse/AMBARI-5170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix Ambari Setup on Ubuntu.
>
> Need to make sure ambari-server setup works fine on Ubuntu
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py acdb683
> ambari-server/src/main/python/ambari_server/utils.py PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py b63a3df
> ambari-server/src/test/python/TestUtils.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19523/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 187 tests in 0.421s
>
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/#review38457
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On March 25, 2014, 4:54 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19523/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 4:54 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-5170
> https://issues.apache.org/jira/browse/AMBARI-5170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix Ambari Setup on Ubuntu.
>
> Need to make sure ambari-server setup works fine on Ubuntu
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py acdb683
> ambari-server/src/main/python/ambari_server/utils.py PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py b63a3df
> ambari-server/src/test/python/TestUtils.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19523/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 187 tests in 0.421s
>
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/
-----------------------------------------------------------
(Updated March 25, 2014, 4:54 p.m.)
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Bugs: AMBARI-5170
https://issues.apache.org/jira/browse/AMBARI-5170
Repository: ambari
Description
-------
Fix Ambari Setup on Ubuntu.
Need to make sure ambari-server setup works fine on Ubuntu
Diffs
-----
ambari-server/src/main/python/ambari-server.py acdb683
ambari-server/src/main/python/ambari_server/utils.py PRE-CREATION
ambari-server/src/test/python/TestAmbariServer.py b63a3df
ambari-server/src/test/python/TestUtils.py PRE-CREATION
Diff: https://reviews.apache.org/r/19523/diff/
Testing
-------
----------------------------------------------------------------------
Ran 187 tests in 0.421s
OK
----------------------------------------------------------------------
Total run:506
Total errors:0
Total failures:0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/
-----------------------------------------------------------
(Updated March 25, 2014, 4:53 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Changes
-------
New patch added
Bugs: AMBARI-5170
https://issues.apache.org/jira/browse/AMBARI-5170
Repository: ambari
Description
-------
Fix Ambari Setup on Ubuntu.
Need to make sure ambari-server setup works fine on Ubuntu
Diffs (updated)
-----
ambari-server/src/main/python/ambari-server.py acdb683
ambari-server/src/main/python/ambari_server/utils.py PRE-CREATION
ambari-server/src/test/python/TestAmbariServer.py b63a3df
ambari-server/src/test/python/TestUtils.py PRE-CREATION
Diff: https://reviews.apache.org/r/19523/diff/
Testing
-------
----------------------------------------------------------------------
Ran 187 tests in 0.421s
OK
----------------------------------------------------------------------
Total run:506
Total errors:0
Total failures:0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/#review38318
-----------------------------------------------------------
Overall refactorings look good to me
ambari-server/src/main/python/ambari-server.py
<https://reviews.apache.org/r/19523/#comment70359>
Let's move this check/command to utils module as well
- Dmitro Lisnichenko
On March 24, 2014, 5:05 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19523/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 5:05 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-5170
> https://issues.apache.org/jira/browse/AMBARI-5170
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix Ambari Setup on Ubuntu.
>
> Need to make sure ambari-server setup works fine on Ubuntu
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 5cec271
> ambari-server/src/main/python/ambari_server/utils.py PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py 54e4077
> ambari-server/src/test/python/TestUtils.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19523/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 187 tests in 0.421s
>
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/
-----------------------------------------------------------
(Updated March 24, 2014, 5:05 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Changes
-------
Patch Updated.
Bugs: AMBARI-5170
https://issues.apache.org/jira/browse/AMBARI-5170
Repository: ambari
Description
-------
Fix Ambari Setup on Ubuntu.
Need to make sure ambari-server setup works fine on Ubuntu
Diffs (updated)
-----
ambari-server/src/main/python/ambari-server.py 5cec271
ambari-server/src/main/python/ambari_server/utils.py PRE-CREATION
ambari-server/src/test/python/TestAmbariServer.py 54e4077
ambari-server/src/test/python/TestUtils.py PRE-CREATION
Diff: https://reviews.apache.org/r/19523/diff/
Testing
-------
----------------------------------------------------------------------
Ran 187 tests in 0.421s
OK
----------------------------------------------------------------------
Total run:506
Total errors:0
Total failures:0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 19523: Fix Ambari Setup on Ubuntu.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19523/
-----------------------------------------------------------
(Updated March 21, 2014, 4:45 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-5170
https://issues.apache.org/jira/browse/AMBARI-5170
Repository: ambari
Description
-------
Fix Ambari Setup on Ubuntu.
Need to make sure ambari-server setup works fine on Ubuntu
Diffs
-----
ambari-server/src/main/python/ambari-server.py 5cec271
Diff: https://reviews.apache.org/r/19523/diff/
Testing
-------
----------------------------------------------------------------------
Ran 187 tests in 0.421s
OK
----------------------------------------------------------------------
Total run:506
Total errors:0
Total failures:0
Thanks,
Vitalyi Brodetskyi