You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2021/07/29 13:55:13 UTC
[GitHub] [incubator-brpc] guodongxiaren opened a new pull request #1503: 增加HTTP协议的dump和rpc_replay功能
guodongxiaren opened a new pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-1023847806
改好了。
@wwbmmm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: 增加HTTP协议的dump和rpc_replay功能
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-891123199
CI通过了，可以帮忙看下代码diff
@zyearn @chenzhangyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
zyearn commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-984127821
好，我之后先看一下 @guodongxiaren
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-903212675
加上了HTTP header的dump功能，借助已有的MakeRawHttpRequest函数，service和method都会存储下来，不再单独给sample->meta中的对应字段赋值。
rpc_replay回放的时候，用ParseFromIOBuf解析该dump的内容，可以自动获取service和method。
另外做了Host字段的清空操作，因为允许录制ServerA的流量，回放给ServerB。如果带着原先的Host，可能引发不必要的问题，比如ServerB是一个Web Apache，会根据Host路由。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-938732411
修改了一下，发现ProcessHttpRequest 这个函数在协议类型为http2的时候也调用，但是我这个dump的代码是只能处理http的。
所以加了一个协议类型的判断。
```cpp
if (sample && !is_http2) {
```
有空的时候，帮忙review一下 @zyearn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-903647687
@TousakaRin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren edited a comment on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren edited a comment on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-892821684
@TousakaRin @zyearn 辛苦各位有空看看
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-894001731
之前rpc_replay不能回放http的，不知道你说的"你记得…"是指哪种情况？😳
我这个没有考虑回放header，dump的结果就是接口和json，然后发送https+json形式的请求。
一般用brpc提供http服务，服务内部也是像std协议一样处理PB吧，很少去从header中取数据吧？我的理解是这样…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] TousakaRin commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
TousakaRin commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-895197464
> 之前rpc_replay不能回放http的，不知道你说的"你记得…"是指哪种情况？😳
> 我这个没有考虑回放header，dump的结果就是接口和json，然后发送https+json形式的请求。
> 一般用brpc提供http服务，服务内部也是像std协议一样处理PB吧，很少去从header中取数据吧？我的理解是这样…
之前我实现过一份http replay，发现dump下来的请求进行replay的时候，http header和原来的请求有一些不匹配。有点儿忘记具体原因了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-981290490
@zyearn 有空看下这个PR吧，好几个月了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: 增加HTTP协议的dump和rpc_replay功能
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-890441520
> 这个CI不稳定额，相同的代码，每次触发会在unittest中不同的地方失败。但是失败的地方不涉及我代码修改的地方。而且我本地测试unittest也是ok的。
辛苦帮忙看下CI的问题：
@zyearn @chenzhangyi @cdjingit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren edited a comment on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren edited a comment on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-903212675
加上了HTTP header的dump功能，借助已有的MakeRawHttpRequest函数，service和method都会存储下来，不再单独给sample->meta中的对应字段赋值。
rpc_replay回放的时候，用ParseFromIOBuf解析该dump的内容，可以自动获取service和method。
另外做了Host字段的清空操作，因为允许录制ServerA的流量，回放给ServerB。如果带着原先的Host，可能引发不必要的问题，比如ServerB是一个Web Apache，会根据Host路由。
已经测试过，可以成功录制和回放。
@zyearn @jamesge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren closed pull request #1503: 增加HTTP协议的dump和rpc_replay功能
Posted by GitBox <gi...@apache.org>.
guodongxiaren closed pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] TousakaRin commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
TousakaRin commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-893969993
我记得用rpc replay来回放http的时候，有部分http header会不一样，不知道你对比过没有
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren edited a comment on pull request #1503: 增加HTTP协议的dump和rpc_replay功能
Posted by GitBox <gi...@apache.org>.
guodongxiaren edited a comment on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-890441520
> 这个CI不稳定额，相同的代码，每次触发会在unittest中不同的地方失败。但是失败的地方不涉及我代码修改的地方。而且我本地测试unittest也是ok的。
这是2次travis运行的任务：
- https://app.travis-ci.com/github/apache/incubator-brpc/builds/234164392
- https://app.travis-ci.com/github/apache/incubator-brpc/builds/234176834
辛苦帮忙看下CI的问题：
@zyearn @chenzhangyi @cdjingit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-895290871
> > 之前rpc_replay不能回放http的，不知道你说的"你记得…"是指哪种情况？😳
> > 我这个没有考虑回放header，dump的结果就是接口和json，然后发送https+json形式的请求。
> > 一般用brpc提供http服务，服务内部也是像std协议一样处理PB吧，很少去从header中取数据吧？我的理解是这样…
>
> 之前我实现过一份http replay，发现dump下来的请求进行replay的时候，http header和原来的请求有一些不匹配。有点儿忘记具体原因了
那我加一个header的dump功能？把header里面的map存下来，回放的时候解析出来，再set回header？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-917613309
@zyearn 加了ut了，进行了request的dump和replay。
不过由于没有办法直接在UT中测试rpc_relay.cpp中的代码，改成在UT中写了一段和本次rpc_replay.cpp中新增的代码相似的代码，来测试。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-1022992975
> > 另外做了Host字段的清空操作，因为允许录制ServerA的流量，回放给ServerB。如果带着原先的Host，可能引发不必要的问题，比如ServerB是一个Web Apache，会根据Host路由。
>
> 感觉这个应该是个可选功能，因为有些场景要求带上原先的Host，不然Server端路由不了，是不是可以加个replay选项？
也可以自己在gflag配置指定：--server=www.abc.com:9999 这个www.abc.com会被拼到Host中。
当然如果www.abc.com指向的经过dns解析出来的机器，不是使用者想要回放的目标机器的时候，需要改下本机hosts文件配置。从这个角度来说，加个新的gflags选项也可以，自己控制是否使用原始host，但完整的Host不止有ip/机器名 也有端口。比如Host: www.abc.com:8888 实际给 另外一个机器的9999端口回放请求。 这个不匹配的端口号，不知道是否会有其他问题。
复杂一点的解法，rpc_replay在保留原Host的时候，再覆盖一下端口号。
@wwbmmm 你觉得呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-1023094454
> 也可以自己在gflag配置指定：--server=www.abc.com:9999 这个www.abc.com会被拼到Host中。
还有一种情况是录制的请求中包含了多个不同Host的请求，这种情况下，无法通过--server的方式去指定不同的Host，所以保留原始Host还是需要的。
> 但完整的Host不止有ip/机器名 也有端口。比如Host: [www.abc.com:8888](http://www.abc.com:8888) 实际给 另外一个机器的9999端口回放请求。 这个不匹配的端口号，不知道是否会有其他问题。
如果需要改端口号，是不是通过指定新Host的方式就可以。感觉“保留原Host”+“新端口号”这个组合挺奇怪的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-1021965920
@wwbmmm 伟冰有空的时候帮看一下我这个PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-1023949185
我这边没问题了，@zyearn 有空也可以再看一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-1023105474
那我改成，新增一个gflag，指定host。未指定的时候保留原host？
```cpp
DEFINE_string(http_host, "", "Host field for http protocol");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-1022949245
> 另外做了Host字段的清空操作，因为允许录制ServerA的流量，回放给ServerB。如果带着原先的Host，可能引发不必要的问题，比如ServerB是一个Web Apache，会根据Host路由。
感觉这个应该是个可选功能，因为有些场景要求带上原先的Host，不然Server端路由不了，是不是可以加个replay选项？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm merged pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
wwbmmm merged pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
zyearn commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-914524440
这个可以写UT来保证正确性吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-892821684
@TousakaRin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren edited a comment on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren edited a comment on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-892821684
@TousakaRin @zyearn 辛苦各位有空看看
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-915083629
> 这个可以写UT来保证正确性吗
不太清楚这种修改，怎么写UT。怎么在单测里调用rpc_replay呢？它自己是包含main函数的可执行文件。
@zyearn
我用example测试过，录制和回放
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-892821684
@TousakaRin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-914392832
@zyearn 这个PR有空的时候也帮忙review一下。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1503: 增加HTTP协议的dump和rpc_replay功能
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-890438341
这个CI不稳定额，相同的代码，每次触发会在unittest中不同的地方失败。但是失败的地方不涉及我代码修改的地方。而且我本地测试unittest也是ok的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren closed pull request #1503: 增加HTTP协议的dump和rpc_replay功能
Posted by GitBox <gi...@apache.org>.
guodongxiaren closed pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1503: support dump and replay for HTTP protocol
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on pull request #1503:
URL: https://github.com/apache/incubator-brpc/pull/1503#issuecomment-1023108159
> 那我改成，新增一个gflag，指定host。未指定的时候保留原host？
可以的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org