You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/08 10:24:02 UTC

[GitHub] [flink] rkhachatryan commented on a change in pull request #16415: [FLINK-23262][tests] Check watermark frequency instead of count

rkhachatryan commented on a change in pull request #16415:
URL: https://github.com/apache/flink/pull/16415#discussion_r666066907



##########
File path: flink-tests/src/test/java/org/apache/flink/test/streaming/api/FileReadingWatermarkITCase.java
##########
@@ -62,8 +64,17 @@ public void testWatermarkEmissionWithChaining() throws Exception {
         JobExecutionResult result = env.execute();
 
         int actual = result.getAccumulatorResult(NUM_WATERMARKS_ACC_NAME);
-
-        assertTrue("too few watermarks emitted: " + actual, actual >= MIN_EXPECTED_WATERMARKS);
+        long expected =
+                result.<Long>getAccumulatorResult(RUNTIME_ACC_NAME) / WATERMARK_INTERVAL_MILLIS;
+        checkState(expected > MIN_EXPECTED_WATERMARKS);
+
+        assertEquals(
+                "too few watermarks emitted in "
+                        + result.<Long>getAccumulatorResult(RUNTIME_ACC_NAME)
+                        + " ms",
+                expected,
+                actual,
+                .5 * expected);

Review comment:
       > Does it mean that the number of checkpoints can be just half of the expected number?
   
   You mean watermarks, not checkpoints, right?
   
   The value is just an empirical number because there are no guarantees regarding the watermark interval (or am I wrong?)
   I'm afraid decreasing it would make the test more flaky (it does fail with `.2` sometimes and rarely with `.3`).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org