You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/25 10:30:10 UTC

[GitHub] [incubator-nuttx] davids5 opened a new pull request #1642: nuttx:board.h add extern C under cpp

davids5 opened a new pull request #1642:
URL: https://github.com/apache/incubator-nuttx/pull/1642


   ## Summary
   
   maintain extern "C" linkage in cpp files
   
   ## Impact
   
   None. But will now work with CPP files.
   
   ## Testing
   
   Build and link and xxx_init.cpp that defines `board_app_initialize`. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1642: nuttx:board.h add extern C under cpp

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 merged pull request #1642:
URL: https://github.com/apache/incubator-nuttx/pull/1642


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #1642: nuttx:board.h add extern C under cpp

Posted by GitBox <gi...@apache.org>.

hartmannathan commented on pull request #1642:
URL: https://github.com/apache/incubator-nuttx/pull/1642#issuecomment-680092113


   Looks good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1642: nuttx:board.h add extern C under cpp

Posted by GitBox <gi...@apache.org>.

acassis commented on pull request #1642:
URL: https://github.com/apache/incubator-nuttx/pull/1642#issuecomment-680125390


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org