You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/12/20 03:41:41 UTC

Review Request 64731: Ended `IOSwitchboard::_prepare` with `UNREACHABLE`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64731/
-----------------------------------------------------------

Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.


Repository: mesos


Description
-------

All paths should `return`, but the compiler wasn't able to determine
this.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 89dd4988c7132d3c7aeacecad7a76961b0ec5a2c 


Diff: https://reviews.apache.org/r/64731/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer

Re: Review Request 64731: Ended `IOSwitchboard::_prepare` with `UNREACHABLE`.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64731/#review194911
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/io/switchboard.cpp
Lines 322-323 (original), 322-323 (patched)
<https://reviews.apache.org/r/64731/#comment273993>

    It should be clearer to place the UNREACHABLE here.  Otherwise the reader needs to scroll all the way up and find where the second `#ifdef` starts.
    
    ```
    #ifdef __WINDOWS__
      // NOTE: On Windows, both return values of
      // `IOSwitchboard::requiresServer(containerConfig)`
      // are checked and will return before reaching here.
      UNREACHABLE();
    #else
      // Other existing stuff...
    #endif // __WINDOWS__
    ```


- Joseph Wu


On Jan. 5, 2018, 1:53 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64731/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 1:53 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> All paths should `return`, but the compiler wasn't able to determine
> this.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 89dd4988c7132d3c7aeacecad7a76961b0ec5a2c 
> 
> 
> Diff: https://reviews.apache.org/r/64731/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 64731: Ended `IOSwitchboard::_prepare` with `UNREACHABLE`.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64731/
-----------------------------------------------------------

(Updated Jan. 5, 2018, 1:53 p.m.)


Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.


Changes
-------

Rebased.


Repository: mesos


Description
-------

All paths should `return`, but the compiler wasn't able to determine
this.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 89dd4988c7132d3c7aeacecad7a76961b0ec5a2c 


Diff: https://reviews.apache.org/r/64731/diff/2/

Changes: https://reviews.apache.org/r/64731/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer