You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/12/06 20:56:46 UTC

[GitHub] [pinot] walterddr commented on a diff in pull request #9917: [multistage] fix decimal types

walterddr commented on code in PR #9917:
URL: https://github.com/apache/pinot/pull/9917#discussion_r1041450413


##########
pinot-query-runtime/src/test/resources/queries/LexicalStructure.json:
##########
@@ -135,11 +135,18 @@
         "inputs": [["1"]]
       }
     },
-    "queries": [{
-      "psql": "4.1.2.6",
-      "description": "numeric constant supports",
-      "sql": "SELECT data, 42, 3.5, 4., .001, 5e2, 1.925e-3 FROM {tbl}"
-    }]
+    "queries": [
+      {
+        "psql": "4.1.2.6",
+        "description": "numeric constant supports",
+        "sql": "SELECT data, 42, 3.5, 4., .001, 5e2, 1.925e-3 FROM {tbl}"

Review Comment:
   got it. will add. i wasn't sure if there's anything new to add on top of the one already there. but will do. (it also tests the RelDataTypeFactory's derive type from `+, -, *, /` methods



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org