[jira] [Commented] (CALCITE-480) Rework RelImplementor so it makes sense to use/implement

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225529#comment-14225529 ] 

Julian Hyde commented on CALCITE-480:
-------------------------------------

I think we could obsolete RelImplementor.

If you have several implementors in play (e.g. if you are implementing a plan that is a hybrid of mongo, enumerable and jdbc) then the implementors have virtually nothing in common.  Each implementor might have some context, which was inherited from its the root RelNode of its particular sub-tree, and might have come from the parent implementor. But there's not a good reason for those implementors to have a common interface.

Obsoleting it will help with CALCITE-466.

> Rework RelImplementor so it makes sense to use/implement
> --------------------------------------------------------
>
>                 Key: CALCITE-480
>                 URL: https://issues.apache.org/jira/browse/CALCITE-480
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.0.0-incubating
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>
> Currently, no methods of {{RelImplementor}} are used in Calcite.
> This is a bit strange since it makes code less understandable/extensible.
> I have no clear plan on the fix, however I think something should be done to unused {{visitChild}} and {{visitChildInternal}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)