You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/10 13:47:52 UTC
[GitHub] [commons-lang] arturobernalg opened a new pull request #769: Minor changes:
arturobernalg opened a new pull request #769:
URL: https://github.com/apache/commons-lang/pull/769
* Inline var
* Simplify conditions
* Make final variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a change in pull request #769: Minor changes
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #769:
URL: https://github.com/apache/commons-lang/pull/769#discussion_r725432382
##########
File path: src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
##########
@@ -1018,7 +1018,7 @@ private static int distance(final Class<?>[] fromClassArray, final Class<?>[] to
final Class<?> acls;
if (interfaceIndex >= allInterfaces.size()) {
acls = allSuperclasses.get(superClassIndex++);
- } else if ((superClassIndex >= allSuperclasses.size()) || (interfaceIndex < superClassIndex) || !(superClassIndex < interfaceIndex)) {
+ } else if ((superClassIndex >= allSuperclasses.size()) || !(superClassIndex < interfaceIndex)) {
Review comment:
The conditions its covered by the condition --> '!(superClassIndex < interfaceIndex)'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #769: Minor changes
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #769:
URL: https://github.com/apache/commons-lang/pull/769#discussion_r725254862
##########
File path: src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
##########
@@ -1018,7 +1018,7 @@ private static int distance(final Class<?>[] fromClassArray, final Class<?>[] to
final Class<?> acls;
if (interfaceIndex >= allInterfaces.size()) {
acls = allSuperclasses.get(superClassIndex++);
- } else if ((superClassIndex >= allSuperclasses.size()) || (interfaceIndex < superClassIndex) || !(superClassIndex < interfaceIndex)) {
+ } else if ((superClassIndex >= allSuperclasses.size()) || !(superClassIndex < interfaceIndex)) {
Review comment:
Not sure if this is correct. Needs analysis. Was this change made by a tool in IntelliJ or Eclipse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #769: Minor changes:
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #769:
URL: https://github.com/apache/commons-lang/pull/769#issuecomment-858653996
[](https://coveralls.io/builds/40477825)
Coverage decreased (-0.0009%) to 94.975% when pulling **56b2c371363dbe6a5639e941958133084de4b26b on arturobernalg:feature/minor_changes** into **197d50434748bfb2db935266cfe740fc01a607ee on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #769: Minor changes
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #769:
URL: https://github.com/apache/commons-lang/pull/769#issuecomment-858653996
[](https://coveralls.io/builds/43385245)
Coverage decreased (-0.0003%) to 94.947% when pulling **79714153e166cd7e223fdcbe853a7d1d31ea1134 on arturobernalg:feature/minor_changes** into **a3a064587470d9ac3be469d0d6dd88f1b95dc669 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #769: Minor changes:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #769:
URL: https://github.com/apache/commons-lang/pull/769#issuecomment-858653996
[](https://coveralls.io/builds/42498974)
Coverage decreased (-0.001%) to 94.96% when pulling **ca43af7a2bf331b172d0728bfea510d4cda93be5 on arturobernalg:feature/minor_changes** into **c28b2e4e717a13527aded2625bbf431506674e9f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #769: Minor changes:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #769:
URL: https://github.com/apache/commons-lang/pull/769#issuecomment-858653996
[](https://coveralls.io/builds/42498974)
Coverage decreased (-0.001%) to 94.96% when pulling **ca43af7a2bf331b172d0728bfea510d4cda93be5 on arturobernalg:feature/minor_changes** into **c28b2e4e717a13527aded2625bbf431506674e9f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org