You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "kulagaIA (via GitHub)" <gi...@apache.org> on 2024/01/04 19:50:26 UTC
[PR] JmsDeliveryDelayTest fix flackiness [camel]
kulagaIA opened a new pull request, #12669:
URL: https://github.com/apache/camel/pull/12669
# Description
testInOnlyWithDelay was flacky because sometimes message is not received from artemis before .assertIsSatisfied(context) is called.
testInOutWithDelay was missing assertions of mock endpoint condition and of response contents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1877673868
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1878563843
> In general, the `StopWatch` (or the standard `Duration` from Java) should be used for computing duration.
>
> Looking at the comments on this test ... I think the right approach is to disable it on github and leave the logic as is.
>
> So, my .2 cents: just disable the test on Github (search for `@DisabledIfSystemProperty` on the code base to see how we do it).
It seems that using StopWatch and measuring elapsed time after .assertIsSatisfied(context) was called, instead of calcualting elapsed time using exchange clock, helped to make this test at least less flacky. I think it can be merged, and if I see it failing again, I'll disable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1878528372
/component-test camel-jms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1877673364
/component-test camel-jms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #12669:
URL: https://github.com/apache/camel/pull/12669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1877698146
> /component-test camel-jms
>
> **Result** ❌ The tests failed please [check the logs](https://github.com/apache/camel/actions/runs/7414143507)
Apparently the problem is in how deliveryDelay is handled in jms component or jms implementation. I'll look into it.
If you have any ideas what else can cause this test to fail, please share :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1877673326
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1878507982
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1878528812
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1878507531
/component-test camel-jms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1878519818
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JmsDeliveryDelayTest fix flackiness [camel]
Posted by "kulagaIA (via GitHub)" <gi...@apache.org>.
kulagaIA commented on PR #12669:
URL: https://github.com/apache/camel/pull/12669#issuecomment-1878519309
/component-test camel-jms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org