You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2012/10/11 08:15:03 UTC

[jira] [Commented] (MAHOUT-1096) Lots of style warnings in generated code are easy to fix

    [ https://issues.apache.org/jira/browse/MAHOUT-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473875#comment-13473875 ] 

Hudson commented on MAHOUT-1096:
--------------------------------

Integrated in Mahout-Quality #1696 (See [https://builds.apache.org/job/Mahout-Quality/1696/])
    MAHOUT-1096 - TIny style fixes in templates (Revision 1396903)

     Result = FAILURE
tdunning : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1396903
Files : 
* /mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/map/OpenKeyTypeValueTypeHashMap.java.t
* /mahout/trunk/math/src/main/java-templates/org/apache/mahout/math/set/OpenKeyTypeHashSet.java.t
* /mahout/trunk/math/src/test/java-templates/org/apache/mahout/math/map/OpenObjectValueTypeHashMapTest.java.t

                
> Lots of style warnings in generated code are easy to fix
> --------------------------------------------------------
>
>                 Key: MAHOUT-1096
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1096
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Ted Dunning
>             Fix For: 0.8
>
>
> We have a method that is protected in our primitive maps and sets.  It is never over-ridden, however, so it might as well be final.  This will nuke between 70-80 high priority style warning.
> We also have some cases of new String("foo") which are easy to fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira