You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/08 17:59:22 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet…

ijuma commented on a change in pull request #10269:
URL: https://github.com/apache/kafka/pull/10269#discussion_r589631664



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -3368,8 +3396,16 @@ object KafkaApis {
   private[server] def sizeOfThrottledPartitions(versionId: Short,
                                                 unconvertedResponse: FetchResponse,
                                                 quota: ReplicationQuotaManager): Int = {
-    FetchResponse.sizeOf(versionId, unconvertedResponse.responseData.entrySet
-      .iterator.asScala.filter(element => quota.isThrottled(element.getKey)).asJava)
+    val topicResponses = new util.ArrayList[FetchResponseData.FetchableTopicResponse]()

Review comment:
       Do we have to create a new collection? The previous version did not.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org