You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/22 19:00:57 UTC

[GitHub] [arrow] xhochy commented on a change in pull request #10963: ARROW-13671: [Dev] Fix conda recipe on Arm 64k page system

xhochy commented on a change in pull request #10963:
URL: https://github.com/apache/arrow/pull/10963#discussion_r693542934



##########
File path: dev/tasks/conda-recipes/arrow-cpp/build-arrow.sh
##########
@@ -43,6 +43,12 @@ else
     EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_GANDIVA=ON"
 fi
 
+if [[ "${target_platform}" == "linux-aarch64" ]]; then
+    # To support both 4k and 64k page arm64 systems
+    # See https://github.com/apache/arrow/pull/10940
+    EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_JEMALLOC_LG_PAGE=16"

Review comment:
       Can you remove the `sed` workaround above for `osx-arm64`?
   ```suggestion
       EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_JEMALLOC_LG_PAGE=16"
   elif [[ "${target_platform}" == "osx-arm64" ]]; then
       EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_JEMALLOC_LG_PAGE=14"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org