You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/05/06 13:14:45 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #6265: Disable skip_failed_rules default
jackwener opened a new pull request, #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4615 #4685 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Disable skip_failed_rules default
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
YES!!!
This PR change default behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener merged pull request #6265: Disable `skip_failed_rules` optimizer config by default
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6265: Disable `skip_failed_rules` optimizer config by default
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265#issuecomment-1538686515
> I prepare to wait for more opinion for it.
Given how many bugs and confusion this rule has caused I strongly support this behavior change -- the fact we have a workaround (to turn on the setting) is great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mingmwang commented on a diff in pull request #6265: Disable `skip_failed_rules` optimizer config by default
Posted by "mingmwang (via GitHub)" <gi...@apache.org>.
mingmwang commented on code in PR #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265#discussion_r1189329328
##########
datafusion/core/tests/sql/subqueries.rs:
##########
@@ -576,6 +576,8 @@ async fn support_order_by_correlated_columns() -> Result<()> {
Ok(())
}
+// TODO: issue https://github.com/apache/arrow-datafusion/issues/6263
Review Comment:
Which rule fail this test ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mingmwang commented on a diff in pull request #6265: Disable `skip_failed_rules` optimizer config by default
Posted by "mingmwang (via GitHub)" <gi...@apache.org>.
mingmwang commented on code in PR #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265#discussion_r1189994251
##########
datafusion/core/tests/sql/subqueries.rs:
##########
@@ -576,6 +576,8 @@ async fn support_order_by_correlated_columns() -> Result<()> {
Ok(())
}
+// TODO: issue https://github.com/apache/arrow-datafusion/issues/6263
Review Comment:
I will fix this rule later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #6265: Disable `skip_failed_rules` optimizer config by default
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265#issuecomment-1541527221
Thanks everyone ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6265: Disable `skip_failed_rules` optimizer config by default
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265#discussion_r1189332589
##########
datafusion/core/tests/sql/subqueries.rs:
##########
@@ -576,6 +576,8 @@ async fn support_order_by_correlated_columns() -> Result<()> {
Ok(())
}
+// TODO: issue https://github.com/apache/arrow-datafusion/issues/6263
Review Comment:
> Which rule fail this test ?
decorrelate_where_in, you can see issue #6263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6265: Disable `skip_failed_rules` optimizer config by default
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265#discussion_r1187631132
##########
datafusion/core/tests/sql/subqueries.rs:
##########
@@ -576,6 +576,8 @@ async fn support_order_by_correlated_columns() -> Result<()> {
Ok(())
}
+// TODO: issue https://github.com/apache/arrow-datafusion/issues/6263
Review Comment:
👍 so only 1 test gets failed on optimization rules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6265: Disable `skip_failed_rules` optimizer config by default
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265#discussion_r1187631435
##########
datafusion/core/tests/sql/subqueries.rs:
##########
@@ -576,6 +576,8 @@ async fn support_order_by_correlated_columns() -> Result<()> {
Ok(())
}
+// TODO: issue https://github.com/apache/arrow-datafusion/issues/6263
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #6265: Disable `skip_failed_rules` optimizer config by default
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #6265:
URL: https://github.com/apache/arrow-datafusion/pull/6265#issuecomment-1538674458
This is a `behavior change` PR.
I prepare to wait for more opinion for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org