You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/11 01:04:32 UTC

[GitHub] [pulsar-client-go] taiyang-li commented on pull request #322: support set logger of pulsar

taiyang-li commented on pull request #322:
URL: https://github.com/apache/pulsar-client-go/pull/322#issuecomment-656955488


   Pulsar-client-go use default logger std allaround.
   
   In most cases, this will work , because users are able to SetOutput SetFormatter SetLevel (refer to https://github.com/sirupsen/logrus/blob/master/exported.go)
   
   But if users already use default logrus logger std before introduce the dependency of pulsar-client-go, and they want to set output/formatter/level different from pulsar-client-go does, there would be a problem.
   
   So I think it is better to use a diffrent default logrus logger(not std) for pulsar-go-client, which will provide much more flexibility of logging for users


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org