[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1603: IGNITE-18569 Fix planning with MRSortAggregate.

["AMashenkov (via GitHub)" <gi...@apache.org>]

AMashenkov commented on code in PR #1603:
URL: https://github.com/apache/ignite-3/pull/1603#discussion_r1092149491


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAggregatesTest.java:
##########
@@ -21,149 +21,216 @@
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import java.util.Arrays;
+import java.util.Locale;
+import java.util.stream.Stream;
 import org.apache.ignite.internal.sql.engine.util.QueryChecker;
+import org.apache.ignite.internal.testframework.WithSystemProperty;
 import org.apache.ignite.lang.IgniteException;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
 
 /**
  * Group of tests to verify aggregation functions.
  */
 public class ItAggregatesTest extends AbstractBasicIntegrationTest {
+    private static String[] disabledRules = {"MapReduceHashAggregateConverterRule", "MapReduceSortAggregateConverterRule",
+            "ColocatedHashAggregateConverterRule", "ColocatedSortAggregateConverterRule"};
+
+    private static final int ROWS = 103;
+
     /**
      * Before all.
      */
     @BeforeAll
     static void initTestData() {
         createAndPopulateTable();
+
+        sql("CREATE TABLE test (id INT PRIMARY KEY, grp0 INT, grp1 INT, val0 INT, val1 INT) WITH replicas=2,partitions=10");
+        sql("CREATE TABLE test_one_col_idx (pk INT PRIMARY KEY, col0 INT)");
+
+        // TODO: https://issues.apache.org/jira/browse/IGNITE-17304 uncomment this
+        // sql("CREATE INDEX test_idx ON test(grp0, grp1)");
+        // sql("CREATE INDEX test_one_col_idx_idx ON test_one_col_idx(col0)");

Review Comment:
   ```suggestion
           sql("CREATE INDEX test_idx ON test(grp0, grp1)");
           sql("CREATE INDEX test_one_col_idx_idx ON test_one_col_idx(col0)");
           
           // FIXME: https://issues.apache.org/jira/browse/IGNITE-18203
           waitForIndex("test_idx");
           waitForIndex("test_one_col_idx_idx");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org