You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/14 18:51:29 UTC
[GitHub] [incubator-superset] mfharding opened a new pull request #9305:
Fixed two typos in the README
mfharding opened a new pull request #9305: Fixed two typos in the README
URL: https://github.com/apache/incubator-superset/pull/9305
I noticed two small typos in the README that I fixed:
1) "Acts" was wrong because it does not have the correct subject-verb agreement
2) "Who Have" is the wrong pronoun to use when referring to companies. "That have" is the grammatically correct option.
Additionally, my company, Let's Roam, uses superset to visualize people completing challenges all over the world.
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #9305: Fixed two
typos in the README
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9305: Fixed two typos in the README
URL: https://github.com/apache/incubator-superset/pull/9305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9305: Fixed two
typos in the README
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9305: Fixed two typos in the README
URL: https://github.com/apache/incubator-superset/pull/9305#issuecomment-599123794
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9305?src=pr&el=h1) Report
> Merging [#9305](https://codecov.io/gh/apache/incubator-superset/pull/9305?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6f40c815a9ed962d5bbbf9dd4fb357479bd3677&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9305?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9305 +/- ##
=======================================
Coverage 59.08% 59.08%
=======================================
Files 374 374
Lines 12202 12202
Branches 2986 2986
=======================================
Hits 7209 7209
Misses 4814 4814
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9305?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9305?src=pr&el=footer). Last update [f6f40c8...72d8e95](https://codecov.io/gh/apache/incubator-superset/pull/9305?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org