You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/05/17 01:02:41 UTC
Review Request 21585: Only set slave subsystems in containerizer tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21585/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Vinod Kone.
Repository: mesos-git
Description
-------
Some tests do no test slave functionalities and may not have cgroups available. Therefore, setting slave subsystems in MesosTest is not ideal as it will make the slave mounting cgroups.
Diffs
-----
src/tests/allocator_tests.cpp 6b7b097
src/tests/environment.cpp 1267b3e
src/tests/master_tests.cpp d74fc94
src/tests/mesos.cpp 7f59b72
src/tests/resource_offers_tests.cpp 56682de
src/tests/slave_recovery_tests.cpp 85c57b2
Diff: https://reviews.apache.org/r/21585/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 21585: Only set slave subsystems in containerizer tests.
Posted by Jie Yu <yu...@gmail.com>.
> On May 17, 2014, 12:35 a.m., Vinod Kone wrote:
> > Please make sure you test this with make check (linux and osx) and sudo make check (linux).
Yes, I did:)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21585/#review43300
-----------------------------------------------------------
On May 16, 2014, 11:02 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21585/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 11:02 p.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Some tests do no test slave functionalities and may not have cgroups available. Therefore, setting slave subsystems in MesosTest is not ideal as it will make the slave mounting cgroups.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 6b7b097
> src/tests/environment.cpp 1267b3e
> src/tests/master_tests.cpp d74fc94
> src/tests/mesos.cpp 7f59b72
> src/tests/resource_offers_tests.cpp 56682de
> src/tests/slave_recovery_tests.cpp 85c57b2
>
> Diff: https://reviews.apache.org/r/21585/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21585: Only set slave subsystems in containerizer tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21585/#review43300
-----------------------------------------------------------
Ship it!
Please make sure you test this with make check (linux and osx) and sudo make check (linux).
- Vinod Kone
On May 16, 2014, 11:02 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21585/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 11:02 p.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Some tests do no test slave functionalities and may not have cgroups available. Therefore, setting slave subsystems in MesosTest is not ideal as it will make the slave mounting cgroups.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 6b7b097
> src/tests/environment.cpp 1267b3e
> src/tests/master_tests.cpp d74fc94
> src/tests/mesos.cpp 7f59b72
> src/tests/resource_offers_tests.cpp 56682de
> src/tests/slave_recovery_tests.cpp 85c57b2
>
> Diff: https://reviews.apache.org/r/21585/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>