[jira] [Created] (HADOOP-17127) Use RpcMetrics.TIMEUNIT to initialize rpc queueTime and processingTime

["Jim Brennan (Jira)" <ji...@apache.org>]

Jim Brennan created HADOOP-17127:
------------------------------------

             Summary: Use RpcMetrics.TIMEUNIT to initialize rpc queueTime and processingTime
                 Key: HADOOP-17127
                 URL: https://issues.apache.org/jira/browse/HADOOP-17127
             Project: Hadoop Common
          Issue Type: Improvement
          Components: common
            Reporter: Jim Brennan
            Assignee: Jim Brennan


While making an internal change to use {{TimeUnit.MICROSECONDS}} instead of {{TimeUnit.MILLISECONDS}} for rpc details, we found that we also had to modify this code in DecayRpcScheduler.addResponseTime() to initialize {{queueTime}} and {{processingTime}} with the correct units.
{noformat}
    long queueTime = details.get(Timing.QUEUE, TimeUnit.MILLISECONDS);
    long processingTime = details.get(Timing.PROCESSING, TimeUnit.MILLISECONDS);
{noformat}
If we change these to use {{RpcMetrics.TIMEUNIT}} it is simpler.

We also found one test case in TestRPC that was assuming the units were milliseconds.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org