You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/07 17:36:34 UTC

[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11118: refactor: Replace react-bootstrap tabs with Antd tabs

kgabryje commented on a change in pull request #11118:
URL: https://github.com/apache/incubator-superset/pull/11118#discussion_r501191862



##########
File path: superset-frontend/spec/javascripts/datasource/DatasourceEditor_spec.jsx
##########
@@ -17,12 +17,12 @@
  * under the License.
  */
 import React from 'react';
-import { Tabs } from 'react-bootstrap';
 import { shallow } from 'enzyme';
 import configureStore from 'redux-mock-store';
 import fetchMock from 'fetch-mock';
 import thunk from 'redux-thunk';
 
+import Tabs from 'src/common/components/Tabs';

Review comment:
       The same comment applies here as in the Popover PR - https://github.com/apache/incubator-superset/pull/11163#discussion_r501041041




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org