You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by alostale <gi...@git.apache.org> on 2016/09/28 11:14:01 UTC
[GitHub] tomcat pull request #34: fixed retrieval org.apache.catalina.startup.EXIT_ON...
GitHub user alostale opened a pull request:
https://github.com/apache/tomcat/pull/34
fixed retrieval org.apache.catalina.startup.EXIT_ON_INIT_FAILURE
This property was incorrectly tried to be retrieved: it converted the
proprety name directly into boolean instead of its value from System
properties.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alostale/tomcat trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit 22a86bd59f3e37d3e079361be1ed2deef857933a
Author: Asier Lostal� <as...@openbravo.com>
Date: 2016-09-28T11:10:36Z
fixed retrieval org.apache.catalina.startup.EXIT_ON_INIT_FAILURE
This property was incorrectly tried to be retrieved: it converted the
proprety name directly into boolean instead of its value from System
properties.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #34: fixed retrieval org.apache.catalina.startup.EXIT_ON_INIT_F...
Posted by alostale <gi...@git.apache.org>.
Github user alostale commented on the issue:
https://github.com/apache/tomcat/pull/34
Sorry, I misread the docs :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #34: fixed retrieval org.apache.catalina.startup.EXIT_ON_INIT_F...
Posted by SvetlinZarev <gi...@git.apache.org>.
Github user SvetlinZarev commented on the issue:
https://github.com/apache/tomcat/pull/34
Nope, Boolean.getBoolean("xxx") tries to convert the value of the system property "xxx" to a boolean or returns false if it's missing. The method name is indeed very misleading, but works as expected.
http://docs.oracle.com/javase/7/docs/api/java/lang/Boolean.html#getBoolean(java.lang.String)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #34: fixed retrieval org.apache.catalina.startup.EXIT_ON...
Posted by alostale <gi...@git.apache.org>.
Github user alostale closed the pull request at:
https://github.com/apache/tomcat/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org