You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/24 13:11:50 UTC
[GitHub] [spark] Ngone51 opened a new pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Ngone51 opened a new pull request #28923:
URL: https://github.com/apache/spark/pull/28923
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR fix `UserDefinedType.equal()` by comparing the UDT class instead of checking `acceptsType()`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
It's weird that equality comparison between two UDT types can have different result by switching the order:
```scala
// ExampleSubTypeUDT.userClass is a subclass of ExampleBaseTypeUDT.userClass
val udt1 = new ExampleBaseTypeUDT
val udt2 = new ExampleSubTypeUDT
println(udt1 == udt2) // true
println(udt2 == udt1) // false
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes.
Before:
```scala
// ExampleSubTypeUDT.userClass is a subclass of ExampleBaseTypeUDT.userClass
val udt1 = new ExampleBaseTypeUDT
val udt2 = new ExampleSubTypeUDT
println(udt1 == udt2) // true
println(udt2 == udt1) // false
```
After:
```scala
// ExampleSubTypeUDT.userClass is a subclass of ExampleBaseTypeUDT.userClass
val udt1 = new ExampleBaseTypeUDT
val udt2 = new ExampleSubTypeUDT
println(udt1 == udt2) // false
println(udt2 == udt1) // false
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-648998703
**[Test build #124486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124486/testReport)** for PR 28923 at commit [`b29cef0`](https://github.com/apache/spark/commit/b29cef0f77fe59474c1c1520c26b9623225f7566).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650586478
**[Test build #124567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124567/testReport)** for PR 28923 at commit [`b29cef0`](https://github.com/apache/spark/commit/b29cef0f77fe59474c1c1520c26b9623225f7566).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-648813979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650973560
**[Test build #124617 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124617/testReport)** for PR 28923 at commit [`28f46de`](https://github.com/apache/spark/commit/28f46debdf5cd50b9e34476d1723d0fde5e6ca3a).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-648813222
**[Test build #124486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124486/testReport)** for PR 28923 at commit [`b29cef0`](https://github.com/apache/spark/commit/b29cef0f77fe59474c1c1520c26b9623225f7566).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650638287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650812833
The PR title, `UserDefinedType.equal() should be symmetrical`, seems to be too strong because we will not backport this to `branch-3.0` or `branch-2.4`. Could you revise a little, @Ngone51 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650865515
**[Test build #124617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124617/testReport)** for PR 28923 at commit [`28f46de`](https://github.com/apache/spark/commit/28f46debdf5cd50b9e34476d1723d0fde5e6ca3a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-717609168
I've backported this into branch-3.0/2.4. For the reason, please see: https://github.com/apache/spark/pull/30157/files#r512494277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650978683
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-648813222
**[Test build #124486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124486/testReport)** for PR 28923 at commit [`b29cef0`](https://github.com/apache/spark/commit/b29cef0f77fe59474c1c1520c26b9623225f7566).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650637926
**[Test build #124567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124567/testReport)** for PR 28923 at commit [`b29cef0`](https://github.com/apache/spark/commit/b29cef0f77fe59474c1c1520c26b9623225f7566).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650862464
@dongjoon-hyun Updated the title, please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28923:
URL: https://github.com/apache/spark/pull/28923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650586572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28923:
URL: https://github.com/apache/spark/pull/28923#discussion_r445254621
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala
##########
@@ -134,6 +134,17 @@ class UserDefinedTypeSuite extends QueryTest with SharedSparkSession with Parque
MyLabeledPoint(1.0, new TestUDT.MyDenseVector(Array(0.1, 1.0))),
MyLabeledPoint(0.0, new TestUDT.MyDenseVector(Array(0.3, 3.0)))).toDF()
+
+ test("equal") {
+ val udt1 = new ExampleBaseTypeUDT
+ val udt2 = new ExampleSubTypeUDT
+ val udt3 = new ExampleSubTypeUDT
+ assert(!(udt1 === udt2))
Review comment:
nit: `!==`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-648811057
@cloud-fan @HyukjinKwon Please take a look, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650978689
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124617/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28923:
URL: https://github.com/apache/spark/pull/28923#discussion_r444951512
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala
##########
@@ -134,6 +134,17 @@ class UserDefinedTypeSuite extends QueryTest with SharedSparkSession with Parque
MyLabeledPoint(1.0, new TestUDT.MyDenseVector(Array(0.1, 1.0))),
MyLabeledPoint(0.0, new TestUDT.MyDenseVector(Array(0.3, 3.0)))).toDF()
+
+ test("equal") {
Review comment:
can we also add a test case for `acceptsType`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-649000203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-648813979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650902382
Thank you, @Ngone51 and all. Today's 3 commits are only test case changes and I tested locally. The main body is already tested. Merged to master for Apache Spark 3.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650586478
**[Test build #124567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124567/testReport)** for PR 28923 at commit [`b29cef0`](https://github.com/apache/spark/commit/b29cef0f77fe59474c1c1520c26b9623225f7566).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650865515
**[Test build #124617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124617/testReport)** for PR 28923 at commit [`28f46de`](https://github.com/apache/spark/commit/28f46debdf5cd50b9e34476d1723d0fde5e6ca3a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650862625
Hi all, I've updated the PR according to your comments. Please take another look, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28923:
URL: https://github.com/apache/spark/pull/28923#discussion_r446690196
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala
##########
@@ -134,6 +134,17 @@ class UserDefinedTypeSuite extends QueryTest with SharedSparkSession with Parque
MyLabeledPoint(1.0, new TestUDT.MyDenseVector(Array(0.1, 1.0))),
MyLabeledPoint(0.0, new TestUDT.MyDenseVector(Array(0.3, 3.0)))).toDF()
+
+ test("equal") {
Review comment:
BTW, @Ngone51 . Although it seems to be considered as `Improvement` and should be `Improvement` due to the behavior change, it would be better if we have a test prefix `SPARK-32090: ` here in this PR. If you don't mind, please add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-649155603
LGTM except for the @cloud-fan comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-651027624
thanks all!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650862713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650586572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28923:
URL: https://github.com/apache/spark/pull/28923#discussion_r446734093
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala
##########
@@ -134,6 +134,17 @@ class UserDefinedTypeSuite extends QueryTest with SharedSparkSession with Parque
MyLabeledPoint(1.0, new TestUDT.MyDenseVector(Array(0.1, 1.0))),
MyLabeledPoint(0.0, new TestUDT.MyDenseVector(Array(0.3, 3.0)))).toDF()
+
+ test("equal") {
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650586329
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-649000203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650862713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28923: [SPARK-32090][SQL] Improve UserDefinedType.equal() to make it be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650978683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28923: [SPARK-32090][SQL] UserDefinedType.equal() should be symmetrical
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28923:
URL: https://github.com/apache/spark/pull/28923#issuecomment-650638287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org