[GitHub] [solr] rmuir commented on a diff in pull request #1201: Disable useless errorprone checks

[GitBox <gi...@apache.org>]

rmuir commented on code in PR #1201:
URL: https://github.com/apache/solr/pull/1201#discussion_r1037409515


##########
gradle/validation/error-prone.gradle:
##########
@@ -67,43 +67,45 @@ allprojects { prj ->
 
             // List of enabled/disabled checks
             // Please keep this synced with https://errorprone.info/bugpatterns when upgrading!
+            // Do *NOT* enable checks based on their name or description. Read the source code and make sure they are useful!
+            // Most error-prone checks are not useful for non-google software.
 
             // On by Default : ERROR

Review Comment:
   the comment refers to the "On by default : ERROR" section of this page: https://errorprone.info/bugpatterns
   
   the idea is to organize our (grouping, order) checks consistent with that page and to update it when updating the error-prone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org