Re: [PATCH] FileUtils needs to handle NetWare volume names in resolveFile, normalize

[Stefan Bodewig <bo...@apache.org>]

Hi Jeff,

I finally came around playing with the FileUtils patches you've
supplied that long ago.  I think we cannot go that route any longer.

Right now, Ant will assume that all file names that start with a
letter and contain a colon at the second position are absolute path
names - something that is dangerous already when run on a Unix system.

You now extend this to "all file names that contain a colon are
absolute path names" and I fear this is stretching things too far, as
you can have legal file names with any number of colons on Unix (I
have one where my Mail reader stored some mail from this group, the
filename is /home/bodewig/News/nnfolder:mail.jakarta-ant for example).

We probably need to break things up, make the factory from FileUtils
that it should be and override resolveFile and normalize in OS
dependent subclasses.  This is the only solution I can see ATM.

Others?

Stefan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [PATCH] FileUtils needs to handle NetWare volume names in resolveFile, normalize

[Magesh Umasankar <um...@apache.org>]

From: "Stefan Bodewig" <bo...@apache.org>

> We probably need to break things up, make the factory from FileUtils
> that it should be and override resolveFile and normalize in OS
> dependent subclasses.  This is the only solution I can see ATM.

+1, to make absolute path decisions based on underlying OS.

Magesh




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>