[GitHub] [spark] peter-toth commented on a diff in pull request #37630: [SPARK-40193][SQL] Merge subquery plans with different filters

["peter-toth (via GitHub)" <gi...@apache.org>]

peter-toth commented on code in PR #37630:
URL: https://github.com/apache/spark/pull/37630#discussion_r1301790844


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkOptimizer.scala:
##########
@@ -62,7 +62,7 @@ class SparkOptimizer(
       RewriteDistinctAggregates) :+
     Batch("Pushdown Filters from PartitionPruning", fixedPoint,
       PushDownPredicates) :+
-    Batch("Cleanup filters that cannot be pushed down", Once,
+    Batch("Cleanup filters that cannot be pushed down", FixedPoint(1),

Review Comment:
   This is because `BooleanSimplification` is not idempotent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org