You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/21 12:07:00 UTC
[jira] [Commented] (S2GRAPH-153) Implement IndexProvider(for Mixed IndexType) class

    [ https://issues.apache.org/jira/browse/S2GRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096173#comment-16096173 ] 

ASF GitHub Bot commented on S2GRAPH-153:
----------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/113

    [S2GRAPH-153]: Implement IndexProvider(for Mixed IndexType) class

    - add IndexProvider Trait.
    - add Reference Implementation for IndexProvider trait using local embedded lucene

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-153

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #113
    
----
commit 1f9693a8fb68487c674d84e92aea30aecc7ece1f
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-10T01:42:25Z

    add ServiceColumnIndex.

commit 6065c87be004651bf629803d37be2d745c72fc3a
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-10T10:21:11Z

    add IndexProvider.

commit e3472de8de46fe4f838a6807f7c6b40ffa1f1df2
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-11T04:54:52Z

    start to add optimize.

commit 7ddc276207a2ef8276d3f40067b64ac06876c48d
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-11T09:48:53Z

    add IndexProvider.

commit 0594fd0760f80d8e51dacd1b8e3549002328edac
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-12T02:56:00Z

    not even compiled.

commit 1cd00df0a7a58f454182d997c0a8c8337a50486a
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-12T22:09:40Z

    add IndexProviderTest.

commit 71d42dc3aa3001b9d511f42b34e35dedd11fbf3f
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-13T01:13:15Z

    test more on IndexProviderTest.

commit a76dfdc207fb26b401f601d45f7aa9e793405a13
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-13T01:13:15Z

    test more on IndexProviderTest.

commit 4bf775359430f7cea0205dbc37890f914d2ee4d8
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-13T06:43:41Z

    bug fix on variant arguments.

commit a16a58de79f1d923df3ac2b0449c0bba7e34df8e
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-13T06:51:21Z

    Merge branch 'graph-index' of github.com:SteamShon/incubator-s2graph into graph-index

commit 1af749f63dbdf78b5d54023e60287191691b1389
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-17T00:59:36Z

    passed tp3 test suites.

commit 33ed1d8d5bbaa2eca46d49a2e6c042fb39754636
Author: DO YUNG YOON <st...@apache.org>
Date:   2017-07-21T12:03:40Z

    run apache-rat.

----


> Implement IndexProvider(for Mixed IndexType) class
> --------------------------------------------------
>
>                 Key: S2GRAPH-153
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-153
>             Project: S2Graph
>          Issue Type: Sub-task
>    Affects Versions: 0.2.0
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>             Fix For: 0.2.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Currently, there is no global index layer in s2graph. One idea to implement global index layer is using search engine and index Edge/Vertex based on their property with Index Configuration.
> In this task, IndexProvider trait, which can be extended by Lucene, ElasticSearch, Solr, etc should be implemented and provide following methods on Edge/Vertex.
> - Indexing
> {noformat}
> - def mutateVertices(vertices: Seq[S2Vertex]): Seq[Boolean]
> - def mutateEdges(edges: Seq[S2Edge]): Seq[Boolean]
> {noformat}
> - Querying
> {noformat}
> - def fetchEdgeIds(queryString: String): java.util.List[EdgeId]
> - def fetchVertexIds(queryString: String): java.util.List[VertexId]
> {noformat}
> I can't decide if return type of Querying APIs should be changed into Future or not so please give any help on this.
> 	



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)