You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mnemonic.apache.org by lql5083psu <gi...@git.apache.org> on 2017/06/12 00:57:43 UTC
[GitHub] incubator-mnemonic pull request #46: MNEMONIC-278 re-structure the folders o...
GitHub user lql5083psu opened a pull request:
https://github.com/apache/incubator-mnemonic/pull/46
MNEMONIC-278 re-structure the folders of docker
MNEMONIC-278 re-structure the folders of docker
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lql5083psu/incubator-mnemonic master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-mnemonic/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit ab4125c28623fe1b6546335300e166f185edecbb
Author: lql5083psu <la...@gmail.com>
Date: 2017-06-12T00:41:49Z
MNEMONIC-278 re-structure the folders of docker
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-mnemonic pull request #46: MNEMONIC-278 re-structure the folders o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-mnemonic/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-mnemonic pull request #46: MNEMONIC-278 re-structure the folders o...
Posted by bigdata-memory <gi...@git.apache.org>.
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/46#discussion_r121739249
--- Diff: docker/README.md ---
@@ -34,7 +33,8 @@ For old version docker v1.10 below, Please replace ARG with ENV and set its valu
Build from git repository
```bash
- $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker
+ $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker:docker-CentOS
+ $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker:docker-Ubuntu
--- End diff --
Please correct the folder name as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-mnemonic pull request #46: MNEMONIC-278 re-structure the folders o...
Posted by bigdata-memory <gi...@git.apache.org>.
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/46#discussion_r121546082
--- Diff: docker/README.md ---
@@ -34,7 +33,8 @@ For old version docker v1.10 below, Please replace ARG with ENV and set its valu
Build from git repository
```bash
- $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker
+ $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker:docker-centos
--- End diff --
Please note the use of letter case, using docker-CentOS instead of docker-centos.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-mnemonic pull request #46: MNEMONIC-278 re-structure the folders o...
Posted by bigdata-memory <gi...@git.apache.org>.
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/46#discussion_r121739198
--- Diff: docker/README.md ---
@@ -34,7 +33,8 @@ For old version docker v1.10 below, Please replace ARG with ENV and set its valu
Build from git repository
```bash
- $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker
+ $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker:docker-CentOS
--- End diff --
Please correct the folder name as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-mnemonic pull request #46: MNEMONIC-278 re-structure the folders o...
Posted by bigdata-memory <gi...@git.apache.org>.
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/46#discussion_r121546202
--- Diff: docker/README.md ---
@@ -34,7 +33,8 @@ For old version docker v1.10 below, Please replace ARG with ENV and set its valu
Build from git repository
```bash
- $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker
+ $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker:docker-centos
--- End diff --
Please also correct the corresponding folder name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-mnemonic pull request #46: MNEMONIC-278 re-structure the folders o...
Posted by bigdata-memory <gi...@git.apache.org>.
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/46#discussion_r121546613
--- Diff: docker/README.md ---
@@ -2,24 +2,23 @@
================================
-This is the "Dockerfile" that will automatically build the environment of this project.
+This is the "Dockerfile" that will automatically build the centos/ubuntu of this project under ubuntu.
--- End diff --
Please correct this sentence.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-mnemonic pull request #46: MNEMONIC-278 re-structure the folders o...
Posted by bigdata-memory <gi...@git.apache.org>.
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/46#discussion_r121546187
--- Diff: docker/README.md ---
@@ -34,7 +33,8 @@ For old version docker v1.10 below, Please replace ARG with ENV and set its valu
Build from git repository
```bash
- $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker
+ $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker:docker-centos
+ $ docker build -t NAME[:TAG] https://github.com/apache/incubator-mnemonic.git#:docker:docker-ubuntu
--- End diff --
Please note the use of letter case, using docker-Ubuntu instead of docker-ubuntu.
Please also correct the corresponding folder name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---