You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Francois Saint-Jacques (JIRA)" <ji...@apache.org> on 2018/12/14 18:39:00 UTC
[jira] [Commented] (ARROW-4030) [CI] Use travis_terminate to halt
builds when a step fails
[ https://issues.apache.org/jira/browse/ARROW-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721676#comment-16721676 ]
Francois Saint-Jacques commented on ARROW-4030:
-----------------------------------------------
It's apparently worse than this. According to comments of the linked issue, Travis will only mark your build as failed only if the last script returned non-zero (essentially behaving like a pipe). I'd recommend moving to the rust technique https://github.com/rust-lang/rust/pull/12513/files
> [CI] Use travis_terminate to halt builds when a step fails
> ----------------------------------------------------------
>
> Key: ARROW-4030
> URL: https://issues.apache.org/jira/browse/ARROW-4030
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Continuous Integration
> Reporter: Wes McKinney
> Priority: Major
> Fix For: 0.12.0
>
>
> I noticed that Travis CI will soldier onward if a step in its {{script:}} block fails. This wastes build time when there is an error somewhere early on in the testing process
> For example, in the main C++ build, if {{travis_script_cpp.sh}} fails, then the subsequent steps will continue.
> It seems the way to deal with this is to add {{|| travis_terminate 1}} to lines that can fail
> see
> https://medium.com/@manjula.cse/how-to-stop-the-execution-of-travis-pipeline-if-script-exits-with-an-error-f0e5a43206bf
> I also found this discussion
> https://github.com/travis-ci/travis-ci/issues/1066
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)