You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/05 10:06:17 UTC

[GitHub] [beam] mosche commented on a diff in pull request #22620: Support VR test including TestStream for Spark runner in streaming mode

mosche commented on code in PR #22620:
URL: https://github.com/apache/beam/pull/22620#discussion_r962732328


##########
sdks/java/core/src/test/java/org/apache/beam/sdk/testing/TestStreamTest.java:
##########
@@ -105,6 +105,9 @@ public void testLateDataAccumulating() {
             .advanceWatermarkTo(instant.plus(Duration.standardMinutes(6)))
             // These elements are late but within the allowed lateness
             .addElements(TimestampedValue.of(4L, instant), TimestampedValue.of(5L, instant))
+            .advanceWatermarkTo(instant.plus(Duration.standardMinutes(10)))

Review Comment:
   @kennknowles Finally back to this, if you could have a look it would be great:)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org