[GitHub] koushik-das commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

[gi...@git.apache.org]

koushik-das commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs
URL: https://github.com/apache/cloudstack/pull/1832#discussion_r114255197
 
 

 ##########
 File path: api/src/com/cloud/exception/AgentUnavailableException.java
 ##########
 @@ -38,4 +40,18 @@ public AgentUnavailableException(long agentId) {
     public AgentUnavailableException(String msg, long agentId, Throwable cause) {
         super("Host " + agentId + ": " + msg, Host.class, agentId, cause);
     }
+
+    public AgentUnavailableException(String msg, long agentId, boolean isCancelled) {
+        this(msg, agentId, null);
+        setIsCancelled(isCancelled);
+    }
+
+    public boolean isCancelled() {
+        return isCancelled;
+    }
+
+    public void setIsCancelled(boolean isCancelled) {
 
 Review comment:
   This setter is getting used only within the ctor, if not used anywhere else this can be removed
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services