You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/28 17:15:16 UTC
[GitHub] [skywalking] hanahmily opened a new pull request #4144: Fix os
maven plugin issues for Eclipse m2e
hanahmily opened a new pull request #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
When building skywalking in Eclipse or Vscode with Java plugin, we will encounter some issues.
- How to fix?
Refer to https://github.com/trustin/os-maven-plugin#issues-with-eclipse-m2e-or-other-ides, to add this plugin to build lifecycle instead of using it as an extension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] hanahmily commented on issue #4144: Fix os maven
plugin issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569469410
> Why do we pay attention on Eclipse now? Even no one maintain the compiling doc for eclipse.
I'm switching my workspace from idea local development to vscode remote development(performance concerns and network issue), vscode uses m2e(eclipse plugin) to build java, so I should fix some compiling issues about it.
> After reading the doc you referred, clearly there is a way rather than changing the project files. I highly prefer don't do this, as no committer or PMC will work on keeping things checked, and no way to verify this by CI.
Yes, there's another way to do it. but if we merge this PR, other developers using Vscode and Eclipse will get benefits. And I will take care of those changes since I'm working with vscode.
As you have reminded, the old way is from grpc-java official example, but my solution is also from mave-os-plugin official suggestion. I think if these changes passed CI test, we don't have any concerns about production release, especially our most committers are using idea as their ide, so if there's something wrong for the development environment, we will find it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng removed a comment on issue #4144: Fix os
maven plugin issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
wu-sheng removed a comment on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569434933
Why do we pay attention on Eclipse now? Even no one maintain the compiling doc for eclipse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4144: Fix os maven plugin
issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569434929
Why do we pay attention on Eclipse now? Even no one maintain the compiling doc for eclipse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4144: Fix os maven plugin
issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569435499
After reading the doc you referred, clearly there is a way rather than changing the project files. I highly prefer don't do this, as no committer or PMC will work on keeping things checked, and no way to verify this by CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4144: Fix os
maven plugin issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569438406
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=h1) Report
> Merging [#4144](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bdff0e02d97b2ba9bdad744d36a66442717bac?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4144 +/- ##
==========================================
+ Coverage 27.18% 27.21% +0.02%
==========================================
Files 1145 1145
Lines 25100 25100
Branches 3629 3629
==========================================
+ Hits 6824 6831 +7
+ Misses 17670 17663 -7
Partials 606 606
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4144/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `61.26% <0%> (+0.9%)` | :arrow_up: |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4144/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `54.16% <0%> (+25%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=footer). Last update [06bdff0...a05651e](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4144: Fix os maven plugin
issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569435058
And you should know, the current way is the way grpc-java provided officially.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4144: Fix os maven
plugin issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569438406
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=h1) Report
> Merging [#4144](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bdff0e02d97b2ba9bdad744d36a66442717bac?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4144 +/- ##
=======================================
Coverage 27.18% 27.18%
=======================================
Files 1145 1145
Lines 25100 25100
Branches 3629 3629
=======================================
Hits 6824 6824
Misses 17670 17670
Partials 606 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=footer). Last update [06bdff0...0247fe6](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4144: Fix os maven
plugin issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4144: Fix os maven plugin
issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569434933
Why do we pay attention on Eclipse now? Even no one maintain the compiling doc for eclipse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4144: Fix os
maven plugin issues for Eclipse m2e
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4144: Fix os maven plugin issues for Eclipse m2e
URL: https://github.com/apache/skywalking/pull/4144#issuecomment-569438406
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=h1) Report
> Merging [#4144](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bdff0e02d97b2ba9bdad744d36a66442717bac?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4144 +/- ##
=======================================
Coverage 27.18% 27.18%
=======================================
Files 1145 1145
Lines 25100 25100
Branches 3629 3629
=======================================
Hits 6824 6824
Misses 17670 17670
Partials 606 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=footer). Last update [06bdff0...0247fe6](https://codecov.io/gh/apache/skywalking/pull/4144?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services