[GitHub] [kafka] guozhangwang commented on a change in pull request #10731: KAFKA-12815: Update JavaDocs of ValueTransformerWithKey

[GitBox <gi...@apache.org>]

guozhangwang commented on a change in pull request #10731:
URL: https://github.com/apache/kafka/pull/10731#discussion_r645869785



##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java
##########
@@ -158,7 +158,11 @@ public void init(final ProcessorContext context) {
             internalProcessorContext.setRecordContext(new ProcessorRecordContext(
                 valueAndTimestamp == null ? UNKNOWN : valueAndTimestamp.timestamp(),
                 -1L, // we don't know the original offset
-                currentContext.partition(),
+                // technically, we know the partition, but in the new `api.Processor` class,
+                // we move to `RecordMetadata` than would be `null` for this case and thus
+                // we won't have the partition information, so it's better to now provide it
+                // here either, to not introduce a regression later on
+                -1,

Review comment:
       SGTM, thanks @mjsax to bring to our attention.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org