[PATCH] Update menubar on language selection

[Oliver Rossmueller <ol...@tuxerra.com>]

The menubar now responds to language selections and updates all it's 
menu items accordingly. I will also update all existing guis to listen 
to the new LocaleChangeEvent to update all labels/buttons/...

The patch is available for download at 
http://www.tuxerra.com/jmeter_patches/lang_switch.tgz.

Oliver

Re: [PATCH] Update menubar on language selection

[Oliver Rossmueller <ol...@tuxerra.com>]

Hi Jordi!

Jordi Salvat i Alabart wrote:
> Hi Oliver.
> 
> I've commited your patch, with a change: the current way for a user to
> express its preferences is the bin/jmeter.properties file, which is
> handled by JMeterUtils. To stay in line with this, I've moved the
> UserPreferences functionality to JMeterUtils: the reinitializeLocale
> method is now renamed to setLocale. I've also added a new property
> "language" to jmeter.properties to define the preferred language in a
> permanent way.
> 
> It would probably have been better to move all resource and 
> user-configuration management functionality to the gui package (or to a 
> new "i18l" package), but that's too much of a change right now.
> 
> Hope you agree with these changes.

My intention was to use the preferences API to store the selected 
language or LaF or the file name of the test plan used the last time. I 
introduced the UserPreferences class to encapsulate this funcionality, 
but JMeterUtils also ok for me.

> 
> Was there a bug associated with this patch which we should now mark as 
> fixed?

I have no knowledge of a bug related with this feature.


Oliver


-- 
Oliver Rossmueller
Software Engineer
Hamburg, Germany
mailto:oliver@tuxerra.com

Re: [PATCH] Update menubar on language selection

[Jordi Salvat i Alabart <js...@atg.com>]

Hi Oliver.

I've commited your patch, with a change: the current way for a user to
express its preferences is the bin/jmeter.properties file, which is
handled by JMeterUtils. To stay in line with this, I've moved the
UserPreferences functionality to JMeterUtils: the reinitializeLocale
method is now renamed to setLocale. I've also added a new property
"language" to jmeter.properties to define the preferred language in a
permanent way.

It would probably have been better to move all resource and 
user-configuration management functionality to the gui package (or to a 
new "i18l" package), but that's too much of a change right now.

Hope you agree with these changes.

Was there a bug associated with this patch which we should now mark as 
fixed?

Salut,

Jordi.

Oliver Rossmueller wrote:
> The menubar now responds to language selections and updates all it's 
> menu items accordingly. I will also update all existing guis to listen 
> to the new LocaleChangeEvent to update all labels/buttons/...
> 
> The patch is available for download at 
> http://www.tuxerra.com/jmeter_patches/lang_switch.tgz.
> 
> Oliver
> 




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>